Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTCH-3073 Address Java compiler warning #828

Merged
merged 5 commits into from
Oct 6, 2024

Conversation

sebastian-nagel
Copy link
Contributor

NUTCH-3073

  • add missing type arguments (Collections, etc.)
  • remove unnecessary casts
  • remove unused variables
  • avoid leaking resources
  • replace (do not use) deprecated methods and fields
  • remove unused imports

- replace (do not use) deprecated methods and fields
- avoid leaking resources
- add missing type arguments (Collections, etc.)
- remove unnecessary casts
- remove unused variables
@lewismc
Copy link
Member

lewismc commented Oct 4, 2024

+1 i happened to be reviewing #826 and pulled this PR. Tested on small crawl in pseudo-deploy mode.

@lewismc lewismc self-requested a review October 4, 2024 16:08
Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sebastian-nagel sebastian-nagel merged commit 4a61208 into apache:master Oct 6, 2024
4 checks passed
@sebastian-nagel sebastian-nagel deleted the NUTCH-3073 branch October 6, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants