Dispatch additional test events #8093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdedic
approved these changes
Jan 2, 2025
| getParametrizedTestEvent(state: SuiteState, testItem: TestItem): any { | ||
| let name = testItem.parent?.id; | ||
| const idx = name?.indexOf(':') || 0; | ||
| return { |
There was a problem hiding this comment.
what will be the behaviour of the rest of the code on testEvents with undefined name and id ?
There was a problem hiding this comment.
That shouldn't happen. But I added explicit check for that case
petrovic-d
force-pushed
the
dispatch-additional-test-events
branch
from
0b6d6ac to
62ae233
Compare
dbalek
approved these changes
Jan 3, 2025
petrovic-d
force-pushed
the
dispatch-additional-test-events
branch
from
62ae233 to
3e3e7b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run Tests in Paralleltest profile