fixes #7996 - space after comma (css)

[wumpz]

Those CSS rule names were separated by a linefeed

.css_one,
.css_two {
}

The linefeed was not displayed and since breadcrumbs are displayed in a single line, it transformed to .css_one,.css_two.

So this PR simply replaces linefeeds with a space.

[matthiasblaesing]

Can you describe how to reproduce the problem? I built from master and there it works without any change:

So what is different in your case?

[wumpz]

The issue was, that multiple rules in breadcrumbs are better readable if there is an additional space between them. In your screenshot it's not.

E.g.

.rule,.rule2
to
.rule, .rule2

Like the issue described.

[matthiasblaesing]

Ok, I thought your problem was, that the rendering was

.rule,
.rule2

with only the first one visible. Then I suggest to indeed push this down into the css module as that is a general problem in the structure scanner there. As you can see in my screenshot, the same issue is present in the navigator view. Given the origin of the two trees is the same it is not to surprising.

[wumpz]

Ok, I thought your problem was, that the rendering was

.rule,
.rule2

with only the first one visible. Then I suggest to indeed push this down into the css module as that is a general problem in the structure scanner there. As you can see in my screenshot, the same issue is present in the navigator view. Given the origin of the two trees is the same it is not to surprising.

The structure parser delivers the list of rules separated by a linefeed like in the editor view and the breadcrumb module simple removes this linefeed with no addition (displayed as HTML I suppose), hence no space between the rules in the list. The same problem is within the navigator view.

I am not familiar with the structure scanner. So how should this rule list delivered so that all displaying parts still work. Now it's quite convenient because it's just a string.

So wouldn't it be the easiest way to simply do the same change in the node factory for a css file?

[matthiasblaesing]

@wumpz

I am not familiar with the structure scanner. So how should this rule list delivered so that all displaying parts still work. Now it's quite convenient because it's just a string.

So wouldn't it be the easiest way to simply do the same change in the node factory for a css file?

Well kind of. The intermediate structure we need to focus on is the StructureItem. The CSL API processes this to generate the navigator structure view and the breadcrumbs for example. The results from a usages search ("Find All Subtype") for that class gives a list, that seems to be manageable (round about 10 subclasses). I think the one you are looking for is org.netbeans.modules.css.editor.module.main.CssRuleStructureItem. Modifiying the name should be enough.