Upgrading nb-javac to JDK 24b29. #8037
Conversation
lahodaj
added
Java
| Object ordinary = null; | ||
|
|
||
| try { | ||
| ordinary = Enum.valueOf((Class<Enum>) Class.forName("com.sun.tools.javac.api.JavacScope$ScopeType"), "ORDINARY"); |
There was a problem hiding this comment.
The ScopeType is currently private in JavacScope. I'll see if there's something that can be done about it, but it seems somewhat unlikely it could be done in JDK24. So it seems we may need to live with code like this. My mistake.
mbien
added
Upgrade Library
|
looks good! In past we would have bumped CI to the next major JDK version in this PR since it updates the major javac version. However, we have a chicken-egg problem with the SM removal proposals. (many java tests do also not work if JDK > nb-javac version and we can't bump CI here since it would fail due to required SM removal changes) I temporarily merged this PR into #7928 which allows us to test both PRs fully for the first time on 24-ea and all tests passed which is great. |
lahodaj
force-pushed
the
upgrade-jdk-24-b27
branch
from
ad679a9 to
c025747
Compare
|
Re-running with "all" tests enabled. If everything is green, and there are no objections, I'll integrate at some point - maybe tomorrow. |
|
Restartet the 3 failing tests. |
|
restarted twice more. we have to check
at some point since it is another test which is failing relatively often. The same happened to me in other PRs #7958 (comment) - so the javać update is not the cause of this. |
mbien
changed the title
|
going to merge this PR once master is green so that we can start testing on JDK 24. We might want to update javac to a later build before release anyway, dependent on what changes make it in till then. |
A first sketch (so far) to attempt to (nb-)javac from JDK 24.