OutputWindow: text selection can start at index 0. #7951
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbien
added
Platform
matthiasblaesing
approved these changes
Nov 10, 2024
|
tracked this bug down just for fun. It got introduced 2005 (19 years ago :)) and moved a little bit through the code base until it found its resting place in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivial fix.
AbstractOutputPane#getSelection()is only called from withinOutputTab#actionPerformedand isn't public API. This should make this fix local and low risk since it doesn't affect anything outside of the find and filter actions of the same module.targets delivery
closes #7942