fs/fcb: Coverity fix #3308
Merged
fs/fcb: Coverity fix #3308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no real problem with the code 356 loc1.fe_area = fcb_get_prev_area(fcb, loc->fe_area); >>> CID 418283: Code maintainability issues (UNUSED_VALUE) >>> Assigning value "0UL" to "loc1.fe_elem_off" here, but that stored value is overwritten before it can be used. 357 loc1.fe_elem_off = 0; This should satisfy coverity Signed-off-by: Jerzy Kasenberg <[email protected]>
sjanc
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no real problem with the code
356 loc1.fe_area = fcb_get_prev_area(fcb, loc->fe_area);
357 loc1.fe_elem_off = 0;
This should satisfy coverity
Additionally call
fcb_start_offset(fcb);in functionfcb_step()is replaced with precomputed value that was used in some place
but not in others