-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change build pom naming from xxx-build.pom to xxx-build-pom.xml #1298
base: master
Are you sure you want to change the base?
Conversation
This does not look wrong. What is the motivation behind this? How will the attached artifact looked like if then main POM is still |
The problem seems to be that sonatype oss release validation fail staging repositories deployed with Maven 4. The issue is there is now more than one .pom file in the repo.
|
That really feels like fixing the symptom...
This names is reasonable since it is the original one with a classifier. Does |
It is. Maybe we should just do nothing and let Sonatype fix on their side ?
Yes, I don't have a clear opinion. I wonder if the I think the best would still be the current state, i.e. |
this is also my expectation...
I also agree on this one. |
@brianf, can you help? |
+1 to fix the name on our side rational is:
|
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MNG-XXX] SUMMARY
,where you replace
MNG-XXX
andSUMMARY
with the appropriate JIRA issue.[MNG-XXX] SUMMARY
.Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.