-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert reports to Guice #803
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are doing hard work that will not be visible in release notes due to lack of jira assigned.
IMHO release notes should be limited to user visible changes. This isn't such. |
Every code changes, refactor and so can have an impact on users ... so should be listed in release notes, maybe on the and of other more important changes. |
Vote about migrating to GitHub issues passed so we could słowny, project by project move to GH Issues. Wdyt @elharo |
This PR probablly isn't the right place to discuss that, unless there's something more specific you wanted to ask? |
Yes, here we ask to register Jira. |
I think release notes, Jira (or Giithub) issues, and PRs are three independent things. There's no 1:1 relationship between them. Each should be written for its audience and purpose. Release notes are for users of the tool. Jira issues are mostly for current developers. PR descriptions are for future developers trying to understand the code. |
If yes, it would be good to have a similar understanding also described on our Maven site, as we have a plan to open reporting issues via gh. |
anyway - good job. |
No description provided.