Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert reports to Guice #803

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Convert reports to Guice #803

wants to merge 7 commits into from

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Dec 20, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 21, 2024 12:29
@elharo elharo requested a review from slachiewicz December 21, 2024 12:29
Copy link
Member

@slachiewicz slachiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing hard work that will not be visible in release notes due to lack of jira assigned.

@elharo
Copy link
Contributor Author

elharo commented Dec 21, 2024

IMHO release notes should be limited to user visible changes. This isn't such.

@slawekjaranowski
Copy link
Member

IMHO release notes should be limited to user visible changes. This isn't such.

Every code changes, refactor and so can have an impact on users ... so should be listed in release notes, maybe on the and of other more important changes.

@slachiewicz
Copy link
Member

Vote about migrating to GitHub issues passed so we could słowny, project by project move to GH Issues. Wdyt @elharo

@elharo
Copy link
Contributor Author

elharo commented Dec 22, 2024

This PR probablly isn't the right place to discuss that, unless there's something more specific you wanted to ask?

@slachiewicz
Copy link
Member

Yes, here we ask to register Jira.

@elharo
Copy link
Contributor Author

elharo commented Dec 22, 2024

I think release notes, Jira (or Giithub) issues, and PRs are three independent things. There's no 1:1 relationship between them. Each should be written for its audience and purpose. Release notes are for users of the tool. Jira issues are mostly for current developers. PR descriptions are for future developers trying to understand the code.

@slachiewicz
Copy link
Member

If yes, it would be good to have a similar understanding also described on our Maven site, as we have a plan to open reporting issues via gh.

@slachiewicz
Copy link
Member

anyway - good job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants