After surefire 2058 #519
After surefire 2058 #519
Conversation
Tibor17
force-pushed
the
AFTER-SUREFIRE-2058
branch
from
345cfe2
to
b5f65fe
Compare
| countDecodedBytes += readInputBytes; | ||
| strings.add( ( (Buffer) output ).flip().toString() ); | ||
| ( (Buffer) output ).clear(); | ||
| memento.getLine().setPositionByteBuffer( 0 ); |
There was a problem hiding this comment.
What's the reason of resetting line position here?
Will give this branch a try later. Maybe compare events dump before and after on single test runs, and just see if larger projects have no other issues.
I think I already tried with removed do-while once, because it was suspicious at first look. But didn't want to change anything else in #518 , but my guess was that that wile condition is never true.
There was a problem hiding this comment.
@zoltanmeze memento.getLine() holds the line which could not be properly decoded and it is eligible for printing a corruption status on the console.
There was a problem hiding this comment.
After properly decoded bytes, we clear the buffer and new bytes will be decoded. The corrupted line has to reset to 0 and remaining is 0 too of course.
There was a problem hiding this comment.
If MalformedFrameException is caught, whole byte sequence is printed as a corrupted string starting by memento.getLine().getPositionByteBuffer() up to the buffer's position.
There was a problem hiding this comment.
I see. Wouldn't read( memento, bytesToRead ); also reset this to 0 in every iteration starting from second?
There was a problem hiding this comment.
The memento holds the reference to the buffer too. And if I clean it up, I should reset the position variable via memento.getLine().setPositionByteBuffer( 0 ) in order to be consistent.
Tibor17
force-pushed
the
AFTER-SUREFIRE-2058
branch
from
b5f65fe
to
72b1841
Compare
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,where you replace
SUREFIRE-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean installto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean install).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.