KAFKA-19915: [2/3] Move HostedPartition to server module#21475
Open
clolov wants to merge 4 commits intoapache:trunkfrom
Open
KAFKA-19915: [2/3] Move HostedPartition to server module#21475clolov wants to merge 4 commits intoapache:trunkfrom
clolov wants to merge 4 commits intoapache:trunkfrom
Conversation
clolov
force-pushed
the
KAFKA-19915-2
branch
from
e5b586c to
28a2b2d
Compare
github-actions
bot
added
the
storage
clolov
changed the title
mimaison
reviewed
Feb 13, 2026
| * log record from the Quorum controller indicating that the broker should be either a leader | ||
| * or follower of a partition. | ||
| */ | ||
| public sealed interface HostedPartition<T> permits None, Online, Offline { } No newline at end of file |
Member
There was a problem hiding this comment.
Could we merge all these files in here?
Contributor
Author
There was a problem hiding this comment.
When I tried doing it Java started complaining that it wants one public record per file. If you have a suggestion on how to silence that I am happy to put them all in the same file?
Contributor
Author
There was a problem hiding this comment.
Hmm, actually, let me try something, maybe I was approaching this the wrong way
Contributor
Author
There was a problem hiding this comment.
Okay, hopefully the latest version address this 😊! I was trying to put the records on the same level as the interface, but they should have been put nested inside the interface!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move HostedPartition to Java