KAFKA-20161 Group configuration for share.renew.acknowledge.enable#21467
Open
DL1231 wants to merge 2 commits intoapache:trunkfrom
Open
KAFKA-20161 Group configuration for share.renew.acknowledge.enable#21467DL1231 wants to merge 2 commits intoapache:trunkfrom
DL1231 wants to merge 2 commits intoapache:trunkfrom
Conversation
github-actions
bot
added
triage
chia7712
changed the title
chia7712
reviewed
Feb 13, 2026
| * @param groupId The group id for which the renew acknowledge enable is to be checked. | ||
| * @return true if renew acknowledge is enabled for the group, false otherwise. | ||
| */ | ||
| public static boolean isRenewAcknowledgeEnabled(GroupConfigManager groupConfigManager, String groupId) { |
Member
There was a problem hiding this comment.
Should we move this to GroupMetadataManager?
Collaborator
Author
There was a problem hiding this comment.
Moving this to GroupMetadataManager would require introducing GroupMetadataManager as a new dependency of SharePartition, which seems like unnecessary coupling. The similar config-accessor methods in
GroupMetadataManager (e.g., consumerGroupSessionTimeoutMs) serve the coordinator's own internal logic, whereas this helper serves the share partition layer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the
share.renew.acknowledge.enablegroup configuration(KIP-1222) to control whether renew acknowledgements are permitted for a
share group.
share.renew.acknowledge.enable(default false) inGroupConfig-When disabled, RENEW acknowledgements are rejected with
INVALID_RECORD_STATEerror code - Update existing RENEW tests toexplicitly enable the config - Add unit tests and integration test
for the disabled-by-default behavior