KAFKA-20134: Implement TimestampedWindowStoreWithHeaders (1/N)#21465
KAFKA-20134: Implement TimestampedWindowStoreWithHeaders (1/N)#21465frankvicky wants to merge 9 commits intoapache:trunkfrom
Conversation
|
This PR shouldn't be merge before #21446 |
mjsax
added
kip
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ |
There was a problem hiding this comment.
This calss does not need reviewing as it is being reviewd here: #21446
| import static org.junit.jupiter.api.Assertions.assertNull; | ||
| import static org.junit.jupiter.api.Assertions.assertTrue; | ||
|
|
||
| public class TimestampedSegmentsWithHeadersTest { |
There was a problem hiding this comment.
@frankvicky wondering why you pushed this class. Maybe skip pushing classes that are already pushed by other PRs. Just keep them local.
aliehsaeedii
left a comment
aliehsaeedii
left a comment
There was a problem hiding this comment.
Overall LG. Thanks.
| class TimestampedSegmentWithHeaders extends RocksDBTimestampedStoreWithHeaders | ||
| implements Comparable<TimestampedSegmentWithHeaders>, Segment { | ||
|
|
||
| public final long id; |
There was a problem hiding this comment.
why is the id public?
There was a problem hiding this comment.
Should we have a public getter instead?
There was a problem hiding this comment.
I follow the current pattern of TimestampedSegment.
I suppose this should be fine since the class is package-private and the field is final.
| import org.apache.kafka.streams.state.internals.metrics.RocksDBMetricsRecorder; | ||
|
|
||
| /** | ||
| * Manages the {@link TimestampedSegmentWithHeaders}s that are used by the * {@link RocksDBTimestampedSegmentedBytesStoreWithHeaders}. |
There was a problem hiding this comment.
is the * before {@link RocksDBTimestampedSegmentedBytesStoreWithHeaders}. needed?
3 participants
This PR add
TimestampedSegmentWithHeaders,TimestampedSegmentsWithHeadersand the corresponding unit tests forthe
TimestampedWindowStoreWithHeadersintroduced in KIP-1271.This PR shouldn't be merge before #21446