KAFKA-20164: Add handleLoadBootstrap to KRaft#21453
Open
mannoopj wants to merge 5 commits intoapache:trunkfrom
Open
KAFKA-20164: Add handleLoadBootstrap to KRaft#21453mannoopj wants to merge 5 commits intoapache:trunkfrom
mannoopj wants to merge 5 commits intoapache:trunkfrom
Conversation
… layer - Add handleLoadBootstrap as abstract method in RaftClient.Listener - Add isCommittedSnapshot() to SnapshotReader interface and RecordsSnapshotReader - Route to handleLoadBootstrap or handleLoadSnapshot in KafkaRaftClient - Add handleLoadBootstrap implementation to QuorumController - Add handleLoadBootstrap implementation to MetadataLoader - Make bootstrapMetadata volatile in QuorumController - Add isCommittedSnapshot support to MetadataLoaderTest MockSnapshotReader - Add handleLoadBootstrap to test classes (ReplicatedCounter, MockRaftClientListener, MockListener)
mannoopj
force-pushed
the
KAFKA-20164
branch
from
d86349e to
9e5dd27
Compare
mannoopj
changed the title
mannoopj
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KAFKA-20164: Adds a new
handleLoadBootstrapcallback toRaftClient.Listenerso that bootstrap snapshots are handled separately from committed snapshots. I've made it so that theQuorumControlleris the only implementation ofRaftClient.Listenerthat handles uncommitted bootstrap snapshot file.RaftClient.java— AddedhandleLoadBootstrapas a method inRaftClient.Listener, updated javadocs forhandleLoadSnapshotandhandleLeaderChangeKafkaRaftClient.java— Routes snapshot loading tohandleLoadBootstraporhandleLoadSnapshotbased on whether the snapshot ID equalsBOOTSTRAP_SNAPSHOT_IDQuorumController.java— AddedhandleLoadBootstrapimplementation with full replay logic for bootstrap snapshotsMetadataLoader.java— AddedhandleLoadBootstrapfunctionMockRaftClientListener.java— AddedhandleLoadBootstrapfunctionReplicatedCounter.java— AddedhandleLoadBootstrapfunctionRaftClientTestContext.java— AddedhandleLoadBootstrapfunctionTestRaftServer.scala— AddedhandleLoadBootstrapfunction