Implement content checksum verification in Lz4BlockInputS…#21442
Open
gurtajsingh1 wants to merge 1 commit intoapache:trunkfrom
Open
Implement content checksum verification in Lz4BlockInputS…#21442gurtajsingh1 wants to merge 1 commit intoapache:trunkfrom
gurtajsingh1 wants to merge 1 commit intoapache:trunkfrom
Conversation
…tream This commit implements the content checksum verification feature for LZ4 compression as indicated by existing TODOs in the codebase. Changes: - Added CONTENT_CHECKSUM_SIZE constant (4 bytes) for content checksum size - Added CONTENT_CHECKSUM_MISMATCH error message constant - Added contentChecksum field for tracking running checksum - Added checksumBuffer for direct buffer handling - Implemented content checksum verification in readBlock() method - Content checksum is computed as XOR of all block checksums The content checksum provides end-to-end data integrity verification for LZ4 compressed frames, following the LZ4 v1.5.1 frame format specification. Signed-off-by: $(git config user.name) <$(git config user.email)>
Member
|
Can we also add tests? Is there an impact on performance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@astubbs @halorgium @alexism @glasser
This commit implements the content checksum verification feature for LZ4 compression as indicated by existing TODOs in the codebase.
Changes:
The content checksum provides end-to-end data integrity verification for LZ4 compressed frames, following the LZ4 v1.5.1 frame format specification.
Delete this text and replace it with a detailed description of your change. The
PR title and body will become the squashed commit message.
If you would like to tag individuals, add some commentary, upload images, or
include other supplemental information that should not be part of the eventual
commit message, please use a separate comment.
If applicable, please include a summary of the testing strategy (including
rationale) for the proposed change. Unit and/or integration tests are expected
for any behavior change and system tests should be considered for larger
changes.