MINOR: Refactor ShareConsumerTest to use ClusterTestExtensions. #18656
Conversation
github-actions
bot
added
triage
AndrewJSchofield
added
KIP-932
| this.cluster = cluster; | ||
| } | ||
|
|
||
| private void setup() { |
There was a problem hiding this comment.
It would be preferable if it was possible to put this in a @BeforeEach method. Is that no longer an option, even with code gymnastics?
There was a problem hiding this comment.
@AndrewJSchofield I think not - since the clusterInstance is not populated at that time. It shows up as null.
Using @BeforeEach - it throws an exception
org.opentest4j.AssertionFailedError
at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:46)
at org.junit.jupiter.api.Assertions.fail(Assertions.java:161)
at kafka.test.api.ShareConsumerTest.setup(ShareConsumerTest.java:144)
...
Caused by: java.lang.NullPointerException: Cannot invoke "org.apache.kafka.common.test.KafkaClusterTestKit.waitForReadyBrokers()" because "this.clusterTestKit" is null
at org.apache.kafka.common.test.api.RaftClusterInvocationContext$RaftClusterInstance.waitForReadyBrokers(RaftClusterInvocationContext.java:219)
at kafka.test.api.ShareConsumerTest.setup(ShareConsumerTest.java:136)
... 17 more
I checked a couple of implementations and they are using this approach to perform pre-test initializations. The internal KafkaClusterTestKit object is not populated when beforeEach is called.
There was a problem hiding this comment.
@mumrah Is there something I am missing?
There was a problem hiding this comment.
At the moment, we can't use the ClusterInstance inside a @BeforeEach with @ClusterTest. I'll see if we can fix that in a safe way.
There was a problem hiding this comment.
Filed #18662 to add support for this. For now, we can do the explicit "setup" call as done in this PR.
ShareConsumerTestsuite usesKafkaClusterTestKitto create kafka clusters and assert various scenarios. However, the current implementation is not open for parameterization.ClusterTestExtensionsand associated abstractions which makes the tests cleaner and easy to parameterise.ShareConsumerinstance creation factory method inClusterInstanceinterface.