Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: add removed controller metrics to zk2kraft #18654

Merged

Conversation

FrankYang0529
Copy link
Member

Followup: #18573 (review)

Add following removed controller metrics to zk2kraft.html.

  • kafka.controller:type=ControllerChannelManager
  • kafka.controller:type=ControllerEventManager
  • kafka.controller:type=KafkaController
  • kafka.controller:type=ControllerStats

Screenshot 2025-01-21 at 8 21 44 PM

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@@ -164,5 +164,16 @@ <h5 class="anchor-heading">Removal metrics</h5>
In Kraft mode, Zookeeper is not used, so the metrics is removed.
</p>
</li>
<li>
<p>
Remove the controller metrics. In Kraft mode, there is no broker which is elected as controller to communicate with ZooKeeper.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This description is not accurate. We don't need to explain the all usage of those metrics, since that is not the purpose of this docs. Maybe we can add those metrics to the line#161? WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I think we should also update description at line#158.

Signed-off-by: PoAn Yang <[email protected]>
</p>
<ul>
<li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li>
<li><code>kafka.controller:type=ControllerChannelManager</code></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we list complete metrics attributes? It would be useful to search specific metrics. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#18658 add complete metrics, so I think PR should follow that pattern too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will follow it. Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated it. Thanks.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge all metrics item into single one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are three listed items for now

Signed-off-by: PoAn Yang <[email protected]>
Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FrankYang0529 could you please merge the following metrics?

        <li>
            <p>
                Remove the metrics which is monitoring the number of Zookeeper migrations.
            </p>
            <ul>
                <li><code>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</code></li>
                <li><code>kafka.controller:type=KafkaController,name=ZkMigrationState</code></li>
            </ul>
            <p>
                Kafka remove all zookeeper dependencies, so the metrics is removed.
            </p>
        </li>
        <li>
            <p>
                Remove the metrics which is monitoring requests waiting in the topic purgatory
            </p>
            <ul>
                <li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
                <li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic</code></li>
            </ul>
            <p>
                In Kraft mode, Zookeeper is not used, so the metrics is removed.
            </p>
        </li>

@chia7712
Copy link
Member

For another, it would be great to attach the screenshot of web page

@FrankYang0529
Copy link
Member Author

Thanks for the suggestion. Updated it.

Screenshot 2025-01-24 at 12 35 54 PM

<p>
Remove the metrics which is monitoring requests waiting in the topic purgatory
</p>
<ul>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please align the order of attributes? type,delayedOperation,name WDYT?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Updated it. Thanks.

Screenshot 2025-01-24 at 8 47 49 PM

Signed-off-by: PoAn Yang <[email protected]>
@chia7712 chia7712 merged commit c774352 into apache:trunk Jan 25, 2025
9 checks passed
@FrankYang0529 FrankYang0529 deleted the minor-add-removed-metrics-to-zk2kraft branch January 25, 2025 15:03
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
chia7712 pushed a commit that referenced this pull request Feb 3, 2025
@chia7712
Copy link
Member

chia7712 commented Feb 3, 2025

cherry-pick to 4.0 branch

pdruley pushed a commit to pdruley/kafka that referenced this pull request Feb 12, 2025
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants