MINOR: add removed controller metrics to zk2kraft #18654
Conversation
Signed-off-by: PoAn Yang <[email protected]>
docs/zk2kraft.html
Outdated
| @@ -164,5 +164,16 @@ <h5 class="anchor-heading">Removal metrics</h5> | |||
| In Kraft mode, Zookeeper is not used, so the metrics is removed. | |||
| </p> | |||
| </li> | |||
| <li> | |||
| <p> | |||
| Remove the controller metrics. In Kraft mode, there is no broker which is elected as controller to communicate with ZooKeeper. | |||
There was a problem hiding this comment.
This description is not accurate. We don't need to explain the all usage of those metrics, since that is not the purpose of this docs. Maybe we can add those metrics to the line#161? WDYT?
There was a problem hiding this comment.
Agree. I think we should also update description at line#158.
Signed-off-by: PoAn Yang <[email protected]>
docs/zk2kraft.html
Outdated
| </p> | ||
| <ul> | ||
| <li><code>kafka.server:type=ZooKeeperClientMetrics,name=ZooKeeperRequestLatencyMs</code></li> | ||
| <li><code>kafka.controller:type=ControllerChannelManager</code></li> |
There was a problem hiding this comment.
Should we list complete metrics attributes? It would be useful to search specific metrics. WDYT?
There was a problem hiding this comment.
#18658 add complete metrics, so I think PR should follow that pattern too.
There was a problem hiding this comment.
I will follow it. Thanks.
There was a problem hiding this comment.
Updated it. Thanks.
There was a problem hiding this comment.
Should we merge all metrics item into single one?
There was a problem hiding this comment.
there are three listed items for now
Signed-off-by: PoAn Yang <[email protected]>
There was a problem hiding this comment.
@FrankYang0529 could you please merge the following metrics?
<li>
<p>
Remove the metrics which is monitoring the number of Zookeeper migrations.
</p>
<ul>
<li><code>kafka.controller:type=KafkaController,name=MigratingZkBrokerCount</code></li>
<li><code>kafka.controller:type=KafkaController,name=ZkMigrationState</code></li>
</ul>
<p>
Kafka remove all zookeeper dependencies, so the metrics is removed.
</p>
</li>
<li>
<p>
Remove the metrics which is monitoring requests waiting in the topic purgatory
</p>
<ul>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li>
<li><code>kafka.server:type=DelayedOperationPurgatory,name=NumDelayedOperations,delayedOperation=topic</code></li>
</ul>
<p>
In Kraft mode, Zookeeper is not used, so the metrics is removed.
</p>
</li>
|
For another, it would be great to attach the screenshot of web page |
Signed-off-by: PoAn Yang <[email protected]>
|
Thanks for the suggestion. Updated it. 
|
| <p> | ||
| Remove the metrics which is monitoring requests waiting in the topic purgatory | ||
| </p> | ||
| <ul> | ||
| <li><code>kafka.server:type=DelayedOperationPurgatory,name=PurgatorySize,delayedOperation=topic</code></li> |
There was a problem hiding this comment.
Could you please align the order of attributes? type,delayedOperation,name WDYT?
There was a problem hiding this comment.
Sounds good to me. Updated it. Thanks.
Signed-off-by: PoAn Yang <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
|
cherry-pick to 4.0 branch |
Reviewers: Chia-Ping Tsai <[email protected]>
Reviewers: Chia-Ping Tsai <[email protected]>
Followup: #18573 (review)
Add following removed controller metrics to
zk2kraft.html.Committer Checklist (excluded from commit message)