Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Update the Outdated method name #18645

Merged
merged 1 commit into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
Original file line number Diff line number Diff line change
Expand Up @@ -260,11 +260,11 @@ class BrokerLifecycleManager(
new OfflineDirBrokerFailureEvent(directory))
}

def resendBrokerRegistrationUnlessZkMode(): Unit = {
eventQueue.append(new ResendBrokerRegistrationUnlessZkModeEvent())
def resendBrokerRegistration(): Unit = {
eventQueue.append(new ResendBrokerRegistrationEvent())
}

private class ResendBrokerRegistrationUnlessZkModeEvent extends EventQueue.Event {
private class ResendBrokerRegistrationEvent extends EventQueue.Event {
override def run(): Unit = {
registered = false
scheduleNextCommunicationImmediately()
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/server/BrokerServer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ class BrokerServer(
})
metadataPublishers.add(brokerMetadataPublisher)
brokerRegistrationTracker = new BrokerRegistrationTracker(config.brokerId,
() => lifecycleManager.resendBrokerRegistrationUnlessZkMode())
() => lifecycleManager.resendBrokerRegistration())
metadataPublishers.add(brokerRegistrationTracker)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class BrokerLifecycleManagerTest {
assertEquals(1000L, manager.brokerEpoch)

// Trigger JBOD MV update
manager.resendBrokerRegistrationUnlessZkMode()
manager.resendBrokerRegistration()

// Accept new registration, response sets epoch to 1200
nextRegistrationRequest(1200L)
Expand Down
Loading