Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: Cleanup zk condition in TransactionsTest, QuorumTestHarness and PlaintextConsumerAssignorsTest #18639

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

MINOR: Cleanup zk condition in TransactionsTest, QuorumTestHarness and PlaintextConsumerAssignorsTest #18639

wants to merge 1 commit into from
+12 −36

Conversation

frankvicky
Copy link
Contributor

There are some if-else cases for zk, we should remove them.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community core Kafka Broker tests Test fixes (including flaky tests) small Small PRs labels Jan 20, 2025
m1a2st
m1a2st reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@m1a2st m1a2st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frankvicky for this PR.
Could you also cleanup QuorumTestHarness and PlaintextConsumerAssignorsTest

@frankvicky
MINOR: Cleanup zk condition in TransactionsTest,
94fa519 
PlaintextConsumerAssignorsTest, QuorumTestHarness
@frankvicky frankvicky force-pushed the cleanup-zk-logic-in-transactions-test branch from 2a55664 to 94fa519 Compare January 20, 2025 15:17
@frankvicky frankvicky changed the title MINOR: Cleanup zk condition in TransactionsTest MINOR: Cleanup zk condition in TransactionsTest, QuorumTestHarness and PlaintextConsumerAssignorsTest Jan 20, 2025
@github-actions github-actions bot removed the triage PRs from the community label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1a2st m1a2st m1a2st left review comments

Assignees
No one assigned
Labels
ci-approved core Kafka Broker small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankvicky @m1a2st @chia7712