KAFKA-18599: Remove Optional wrapping for forwardingManager in ApiVersionManager #18630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
ijuma
reviewed
Jan 22, 2025
core/src/test/scala/unit/kafka/server/ApiVersionManagerTest.scala
Outdated
Show resolved
Hide resolved
ijuma
pushed a commit
that referenced
this pull request
Jan 24, 2025
…sionManager (#18630) `forwardingManager` is always present now. Reviewers: Ismael Juma <[email protected]>
pranavt84
pushed a commit
to pranavt84/kafka
that referenced
this pull request
Jan 27, 2025
…sionManager (apache#18630) `forwardingManager` is always present now. Reviewers: Ismael Juma <[email protected]>
airlock-confluentinc bot
pushed a commit
to confluentinc/kafka
that referenced
this pull request
Jan 27, 2025
…sionManager (apache#18630) `forwardingManager` is always present now. Reviewers: Ismael Juma <[email protected]>
mingyen066
deleted the
KAFKA-18599-Remove-Optional-wrapping-for-ForwardingManager-field-in-ApiVersionManager-class
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we can always get forwardingManager now, unwrap the Optional for the forwardingManager field in ApiVersionManager.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)