MINOR Remove needs-attention label after review #18366
Open
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on my fork 
|
chia7712
reviewed
Jan 1, 2025
| @@ -57,6 +57,21 @@ jobs: | |||
| issue_number: pull.number, | |||
| name: "triage" | |||
| }); | |||
| try { | |||
There was a problem hiding this comment.
Out of curiosity, why do we have extra logging specifically for removing the needs-attention label? We don't seem to have similar logging for other labels like triage.
There was a problem hiding this comment.
Since the issue search is filtering for label:triage, we know all the found PRs will have that label. We do log something for each of this (on L53)
console.log("Removing 'triage' label from PR " + pull.number + " : " + pull.title);
To be consistent, I thought we should log a message when we remove "needs-attention".
This log line is a bit extraneous. I'll remove it
console.log("PR did not have 'needs-attention' label");
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from #18147 to also remove the needs-attention label