Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: Remove PureJavaCrc32C and reflective code for CRC32C #18361

Merged
merged 2 commits into from
Jan 1, 2025

Conversation

ijuma
Copy link
Member

@ijuma ijuma commented Dec 31, 2024

This is no longer required since we dropped support for Java 8. Also update NOTICE* and
spotbugs-exclude.xml files.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

This is no longer required since we dropped support for Java 8.
Copy link
Member

@mumrah mumrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the build Gradle build or GitHub Actions label Dec 31, 2024
@ijuma
Copy link
Member Author

ijuma commented Dec 31, 2024

@chia7712 Good point, I addressed your comment.

@ijuma ijuma merged commit 083e344 into apache:trunk Jan 1, 2025
9 checks passed
@ijuma ijuma deleted the simplify-checksums branch January 1, 2025 10:08
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 3, 2025
…8361)

This is no longer required since we dropped support for Java 8. Also update `NOTICE*` and
`spotbugs-exclude.xml` files.

Reviewers: Chia-Ping Tsai <[email protected]>, David Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions clients
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants