MINOR: KAFKA-18280 follow up #18358
Open
MINOR: KAFKA-18280 follow up #18358
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
TaiJuWu
force-pushed
the
sec_followup
branch
from
84bf5f8 to
418bc0b
Compare
TaiJuWu
force-pushed
the
sec_followup
branch
4 times, most recently
from
60bc20d to
4355ee0
Compare
TaiJuWu
force-pushed
the
sec_followup
branch
from
4355ee0 to
24ba970
Compare
ijuma
reviewed
Dec 31, 2024
| @@ -593,6 +593,9 @@ def close_port(self, listener_name): | |||
|
|
|||
| def start_minikdc_if_necessary(self, add_principals=""): | |||
| has_sasl = self.security_config.has_sasl | |||
| # Since KafkaService is utilized by both controller and broker, we do not set miniKDC to None. | |||
| # This avoids the creation of an additional miniKDC, which could result in a mismatch | |||
| # between client and server tokens if two miniKDC instances are running concurrently. | |||
| if has_sasl: | |||
There was a problem hiding this comment.
One question: this implies that has_sasl returns false for one of the controller or broker?
There was a problem hiding this comment.
This depend on KafkaService config.
When controller or broker is created, it will check their configs and decide to wherther utilize SASL.
That means we will check both configurations of broker and controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #18308 (comment)
Committer Checklist (excluded from commit message)