Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR Remove some flaky annotations #18357

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

mumrah
Copy link
Member

@mumrah mumrah commented Dec 31, 2024

Thanks to the efforts of the community, several flaky tests have been fixed.

  • RemoteLogManagerTest#testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally
  • All the children of BaseConsumerTest#testCoordinatorFailover
  • TransactionsTest#testFailureToFenceEpoch
  • TransactionsTest#testReadCommittedConsumerShouldNotSeeUndecidedData
  • MetricsDuringTopicCreationDeletionTest#testMetricsDuringTopicCreateDelete
  • ProduceRequestTest#testProduceWithInvalidTimestamp

@github-actions github-actions bot added core Kafka Broker tests Test fixes (including flaky tests) tiered-storage Related to the Tiered Storage feature small Small PRs labels Dec 31, 2024
@mumrah
Copy link
Member Author

mumrah commented Dec 31, 2024

Copy link
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mumrah should we close the related jiras after this PR gets merged?

@mumrah mumrah merged commit a2a8d87 into apache:trunk Jan 2, 2025
8 of 9 checks passed
@mumrah
Copy link
Member Author

mumrah commented Jan 2, 2025

I resolved the associated Jiras ✅

airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 3, 2025
Remove the flaky annotation from the following tests

* RemoteLogManagerTest#testFetchOffsetByTimestampWithTieredStorageDoesNotFetchIndexWhenExistsLocally
* All the children of BaseConsumerTest#testCoordinatorFailover
* TransactionsTest#testFailureToFenceEpoch
* TransactionsTest#testReadCommittedConsumerShouldNotSeeUndecidedData
* MetricsDuringTopicCreationDeletionTest#testMetricsDuringTopicCreateDelete
* ProduceRequestTest#testProduceWithInvalidTimestamp

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Kafka Broker small Small PRs tests Test fixes (including flaky tests) tiered-storage Related to the Tiered Storage feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants