Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KAFKA-18347: Add tools-log4j2.yaml to config and remove unsed tools-log4j.properties from config #18351

Merged
merged 1 commit into from
Jan 1, 2025
Merged

KAFKA-18347: Add tools-log4j2.yaml to config and remove unsed tools-log4j.properties from config #18351

merged 1 commit into from
Jan 1, 2025

Conversation

frankvicky
Copy link
Contributor

JIRA: KAFKA-18347

as tile, after upgrade log4j2, we should also migrate config from log4j to log4j2.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community small Small PRs labels Dec 30, 2024
@frankvicky
Copy link
Contributor Author

Run quickstart:
Screenshot from 2024-12-30 21-03-44

@frankvicky
Copy link
Contributor Author

Hi @chia7712
Could you please take a look ?
Many thanks 😸

@chia7712
Copy link
Member

@frankvicky could you please run the tool script on your local? also, please run some tool e2e

@frankvicky
Copy link
Contributor Author

I have run kafka-topics.sh:
Screenshot from 2025-01-01 11-49-07

@frankvicky
Copy link
Contributor Author

connect_test.py

================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id:       2024-12-31--008
run time:         5 minutes 40.623 seconds
tests run:        7
passed:           7
flaky:            0
failed:           0
ignored:          0
================================================================================

@chia7712 chia7712 merged commit 5ae4b62 into apache:trunk Jan 1, 2025
10 checks passed
chia7712 pushed a commit that referenced this pull request Jan 1, 2025
@frankvicky @chia7712
KAFKA-18347 Add tools-log4j2.yaml to config and remove unsed tools-lo…
15f6c9b 
…g4j.properties from config (#18351)

Reviewers: Chia-Ping Tsai <[email protected]>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 3, 2025
@frankvicky @adixitconfluent
KAFKA-18347 Add tools-log4j2.yaml to config and remove unsed tools-lo…
53c55ae 
…g4j.properties from config (apache#18351)

Reviewers: Chia-Ping Tsai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-approved small Small PRs triage PRs from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankvicky @chia7712