KAFKA-18371 TopicBasedRemoteLogMetadataManagerConfig exposes sensitive configuration data in logs #18349
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
triage
Wadimz
commented
Dec 30, 2024
| ", commonProps=" + commonProps + | ||
| ", consumerProps=" + consumerProps + | ||
| ", producerProps=" + producerProps + | ||
| ", commonProps=" + configMapToRedactedString(commonProps, AdminClientConfig.configDef()) + |
There was a problem hiding this comment.
commonProps used to create AdminClient only
chia7712
reviewed
Dec 30, 2024
| ", producerProps=" + producerProps + | ||
| ", commonProps=" + configMapToRedactedString(commonProps, AdminClientConfig.configDef()) + | ||
| ", consumerProps=" + configMapToRedactedString(consumerProps, ConsumerConfig.configDef()) + | ||
| ", producerProps=" + configMapToRedactedString(producerProps, ProducerConfig.configDef()) + |
There was a problem hiding this comment.
Please add a unit test to verify that no sensitive strings are output
There was a problem hiding this comment.
@chia7712 thanks for the review! Updated test to include validations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issue described in KAFKA-18371
It was noticed that sensitive information is printed as clear text while using default TopicBasedRemoteLogMetadataManagerConfig implementation. Example:
2024-12-20 14:52:56,805] INFO Successfully configured topic-based RLMM with config: TopicBasedRemoteLogMetadataManagerConfig{clientIdPrefix='__remote_log_metadata_client_6', metadataTopicPartitionsCount=50, consumeWaitMs=120000, metadataTopicRetentionMs=-1, metadataTopicReplicationFactor=3, initializationRetryMaxTimeoutMs=120000, initializationRetryIntervalMs=100, commonProps={request.timeout.ms=10000, ssl.client.auth=none, ssl.keystore.location=/etc/eystore.p12, bootstrap.servers=server1:9094, security.protocol=SASL_SSL, password=CLEARTEXT, ssl.truststore.location=/etc/cacerts, ssl.keystore.password=CLEARTEXT, sasl.mechanism=SCRAM-SHA-512, ssl.key.password=CLEARTEXT, sasl.jaas.config=org.apache.kafka.common.security.scram.ScramLoginModule required username="username" password="CLEARTEXT";, ssl.truststore.password=CLEARTEXT, …Committer Checklist (excluded from commit message)