KAFKA-18356 Explicitly setting up instrumentation for inline mocking (Java 21+) #18339
Conversation
github-actions
bot
added
triage
build.gradle
Outdated
| mockitoAgent { | ||
| transitive = false | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we not do this once for all projects?
There was a problem hiding this comment.
but not all projects need mockitoAgent, eg ':test-common:test-common-runtime', ':group-coordinator:group-coordinator-api', so I think its better for configuring it for separate projects
There was a problem hiding this comment.
What's the downside of enabling it for those projects and how many such projects exist?
There was a problem hiding this comment.
The downside is these projects need to implement libs.mockitoCore dependency which it doesn't need, and the following projects doesn't need it ':test-common:test-common-runtime', ':group-coordinator:group-coordinator-api', ':examples', ':generator', ':tools:tools-api', ':shell', ':streams:streams-scala', ':streams:examples', ':connect:transforms', ':connect:json', ':connect:mirror-client', ':connect:test-plugins'
There was a problem hiding this comment.
Could we enable it automatically if the mockitoCore dependency is added to a project?
There was a problem hiding this comment.
It's a good idea, I will try for it :)
Jira: https://issues.apache.org/jira/browse/KAFKA-18356
Starting from Java 21, the JDK restricts the ability of libraries to attach a Java agent to their own JVM. As a result, the inline-mock-maker might not be able to function without an explicit setup to enable instrumentation, and the JVM will always display a warning.
The mockito document
Test in my local
trunk:
this branch:
Committer Checklist (excluded from commit message)