KAFKA-18052: Decouple the dependency of feature stable version to the metadata version #17886
+88
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongnuo123
changed the title
dongnuo123
changed the title
jolshan
reviewed
Nov 20, 2024
server-common/src/main/java/org/apache/kafka/server/common/TestFeatureVersion.java
Outdated
Show resolved
Hide resolved
dongnuo123
changed the title
junrao
reviewed
Nov 21, 2024
| this.name = name; | ||
| this.featureVersions = featureVersions; | ||
| this.latestProduction = latestProduction; | ||
|
|
||
| if (defaultValue(MetadataVersion.LATEST_PRODUCTION) > latestProduction.featureLevel()) { |
There was a problem hiding this comment.
Do we need to further validate the following?
- The dependencies of the latestProduction is in production.
- The dependencies of the default feature is in production and have a level <= the default level of the dependency.
There was a problem hiding this comment.
Added a validation for
- The latest production value >= the default value.
- The dependencies of the latest production value <= their latest production values.
- The dependencies of the default value <= their default values.
The dependencies of the default feature is in production
This is guaranteed when checking The latest production value >= the default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the validation of feature upgrade relies on the supported version range generated during registration. For a given feature, its max supported feature version in production is set to be the default version value (the latest feature version with bootstrap metadata value smaller or equal to the latest production metadata value).
This patch introduces a
LATEST_PRODUCTIONvalue independent from the metadata version to each feature so that the highest supported feature version can be customized by the feature owner.The change only applies to dynamic feature upgrade. During formatting, we still use the default value associated the metadata version.
Committer Checklist (excluded from commit message)