Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR triage workflow #17881

Open
wants to merge 15 commits into
base: trunk
Choose a base branch
from
Open

Add PR triage workflow #17881

wants to merge 15 commits into from

Conversation

mumrah
Copy link
Contributor

@mumrah mumrah commented Nov 20, 2024

Replaces #17298.

This patch adds a simple label based workflow for PRs. PRs opened by non-committers will have a triage label automatically added. This allows committers to see which PRs need to be triaged. After 7 days, a needs-attention label will be added. This serves as a reminder to committers and allows them to see which PRs have languished.

For now, the triage label will need to be manually removed by a committer. In the future, we could try to automate this by removing the label after a PR has been reviewed, assigned, or commented on.

@github-actions github-actions bot added build Gradle build or GitHub Actions small Small PRs labels Nov 20, 2024
@chia7712
Copy link
Contributor

I totally love this idea!

After 7 days, a needs-attention label will be added. This serves as a reminder to committers and allows them to see which PRs have languished.

Could we just add label "needs-attention" if the PRs from non-committer have no reviewer after 7 days? That may be more simple and it can remind committers to check those languished PRs as well

@fvaleri
Copy link
Contributor

fvaleri commented Nov 21, 2024

I like this, thanks @mumrah.

@mumrah
Copy link
Contributor Author

mumrah commented Nov 21, 2024

@chia7712

Could we just add label "needs-attention" if the PRs from non-committer have no reviewer after 7 days?

Unfortunately, pull_request_reviewed has the same issues as pull_request, but there is no pull_request_reviewed_target event to allow editing details of the PR. I tried a few things, but ultimately don't think we can achieve much automation as the result of a review being submitted :(

So, for now it would be a manual process to remove the triage label. If the triage label is removed, the needs-attention label will not be applied.

One improvement we can make is to use https://github.com/actions/stale?tab=readme-ov-file#exempt-all-pr-assignees to prevent needs-attention from being added if the PR has an assignee. This might not be that useful since we rarely use assignee.

Edit: Since we already require adding ci-approved, it seems that requiring a removal or triage is not too burdensome for committers. After all, it is only a few clicks in the UI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Gradle build or GitHub Actions small Small PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants