KAFKA-14587: Move AclCommand to tools #17880
Open
+636
−583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
commented
Nov 20, 2024
| @@ -303,7 +294,7 @@ public void testUseBootstrapServerOptWithBootstrapControllerOpt() { | |||
| @Test | |||
| public void testUseWithoutBootstrapServerOptAndBootstrapControllerOpt() { | |||
| assertInitializeInvalidOptionsExitCodeAndMsg( | |||
| Collections.emptyList(), | |||
| Collections.singletonList(ADD), | |||
There was a problem hiding this comment.
Actually if you don't provide any arguments on the CLI, just the help message is printed.
The previous test was expecting a different behavior as maybePrintHelpOrVersion() used to be called in main() while I moved it to AclCommandOptions.checkArgs() for consistency with the other tools, and consistency with the CLI behavior.
mimaison
commented
Nov 20, 2024
| @@ -355,7 +346,7 @@ public void testInvalidArgs() { | |||
| "Option \"[list]\" can't be used with option \"[producer]\"" | |||
| ); | |||
| assertInitializeInvalidOptionsExitCodeAndMsg( | |||
| Arrays.asList(BOOTSTRAP_SERVER, LOCALHOST, ADD, PRODUCER, OPERATION), | |||
| Arrays.asList(BOOTSTRAP_SERVER, LOCALHOST, ADD, PRODUCER, OPERATION, "all"), | |||
There was a problem hiding this comment.
Running the same command on the CLI did not produce that error message, so this test was effectively testing internal logic that would not be reachable for users.
./bin/kafka-acls.sh --bootstrap-server localhost:9092 --add --producer --operation
Exception in thread "main" joptsimple.OptionMissingRequiredArgumentException: Option operation requires an argument
To produce that error message from the CLI you need to specify an operation.
mimaison
force-pushed
the
kafka-14587
branch
from
6a3627d
to
50115da
Compare
mimaison
force-pushed
the
kafka-14587
branch
from
50115da
to
49120e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)