Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAFKA-18039: Test all versions of quorum responses in RequestResponseTest #17873

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

peterxcli
Copy link
Contributor

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

- Modified createDescribeQuorumResponse, createEndQuorumEpochResponse, and createBeginQuorumEpochResponse methods to accept a version parameter.
- Adjusted logic to set properties based on the version, ensuring compatibility with different response versions.
- Added node endpoint handling for EndQuorumEpochResponse and BeginQuorumEpochResponse based on version checks.
@github-actions github-actions bot added tests Test fixes (including flaky tests) clients small Small PRs labels Nov 20, 2024
@peterxcli
Copy link
Contributor Author

@ahuang98 Hi, This PR is ready, could you please take a look, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clients small Small PRs tests Test fixes (including flaky tests)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant