Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] KAFKA-17243 - MetadataQuorumCommand describe to include CommittedVoters #17871

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

peterxcli
Copy link
Contributor

@peterxcli peterxcli commented Nov 20, 2024

kafka-metadata-quorum describe --status output should include CommittedVoters information, formatted similarly to Voters and Observers

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

- Introduce committedVoters field in QuorumInfo class
- Update KafkaAdminClient to populate committedVoters from partition info
- Add getter method for committedVoters in QuorumInfo
- Rename `voterStates` to `currentVoterStates` for clarity
- Update all references to use the new name
- Add `currentVoterStates()` getter method
- Remove unused `voterStates()` method
…ateMachine

- Introduce new method `lastVoterSetWithOffset()` in KRaftControlRecordStateMachine
- Return a Map.Entry containing the last VoterSet and its corresponding offset
- Synchronize access to voterSetHistory for thread safety
…rum API

- Add committedVoterStates to LeaderState to track committed voters
- Update LeaderState to manage both current and committed voter states
- Modify KafkaRaftClient to use new lastVoterSetWithOffset method
- Extend RaftUtil.buildDescribeQuorumResponse to include committed voters
- Update DescribeQuorum API to support committed voters (version 3)
@mumrah
Copy link
Contributor

mumrah commented Nov 20, 2024

@peterxcli could you add a more descriptive title and description to this PR rather than just the jira ticket?

@peterxcli peterxcli changed the title [WIP] KAFKA-17243 [WIP] KAFKA-17243 - MetadataQuorumCommand describe to include CommittedVoters Nov 21, 2024
@peterxcli
Copy link
Contributor Author

Hi @mumrah, thanks for the reminder!
Actually, I'm not sure if this PR (Jira ticket) will proceed, as it requires a KIP due to changes in the common message(DescribeQuorumResponse). I should wait for Jose's or Alyssa's response to confirm if this change is really necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants