Skip to content

Commit

Permalink
MINOR: rename resendBrokerRegistrationUnlessZkMode to `resendBroker…
Browse files Browse the repository at this point in the history
…Registration` (#18645)

Reviewers: Chia-Ping Tsai <[email protected]>
  • Loading branch information
m1a2st authored Jan 23, 2025
1 parent 400ecab commit 7e46087
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions core/src/main/scala/kafka/server/BrokerLifecycleManager.scala
Original file line number Diff line number Diff line change
Expand Up @@ -260,11 +260,11 @@ class BrokerLifecycleManager(
new OfflineDirBrokerFailureEvent(directory))
}

def resendBrokerRegistrationUnlessZkMode(): Unit = {
eventQueue.append(new ResendBrokerRegistrationUnlessZkModeEvent())
def resendBrokerRegistration(): Unit = {
eventQueue.append(new ResendBrokerRegistrationEvent())
}

private class ResendBrokerRegistrationUnlessZkModeEvent extends EventQueue.Event {
private class ResendBrokerRegistrationEvent extends EventQueue.Event {
override def run(): Unit = {
registered = false
scheduleNextCommunicationImmediately()
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/scala/kafka/server/BrokerServer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ class BrokerServer(
})
metadataPublishers.add(brokerMetadataPublisher)
brokerRegistrationTracker = new BrokerRegistrationTracker(config.brokerId,
() => lifecycleManager.resendBrokerRegistrationUnlessZkMode())
() => lifecycleManager.resendBrokerRegistration())
metadataPublishers.add(brokerRegistrationTracker)


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ class BrokerLifecycleManagerTest {
assertEquals(1000L, manager.brokerEpoch)

// Trigger JBOD MV update
manager.resendBrokerRegistrationUnlessZkMode()
manager.resendBrokerRegistration()

// Accept new registration, response sets epoch to 1200
nextRegistrationRequest(1200L)
Expand Down

0 comments on commit 7e46087

Please sign in to comment.