This repository was archived by the owner on Aug 6, 2025. It is now read-only.
For EC2, Introduce "allocationId" to IP Address and a new describeRouteTablesWithFilter method for searching RouteTables #202
Closed
qpointsystems wants to merge 3 commits intoapache:masterfrom
qpointsystems:master
Closed
For EC2, Introduce "allocationId" to IP Address and a new describeRouteTablesWithFilter method for searching RouteTables #202qpointsystems wants to merge 3 commits intoapache:masterfrom qpointsystems:master
qpointsystems wants to merge 3 commits intoapache:masterfrom
qpointsystems:master
Conversation
…t the describeAddresssesInRegion method of the IP Client will contain this information.
…ility similar to other EC2 objects that have a "describeXXXWithFilter" method along with their base "describeXXX" method. Also modified the appropriate unit test with a test for this method
nacx
reviewed
Apr 2, 2024
Member
nacx
left a comment
nacx
left a comment
There was a problem hiding this comment.
Thank you!
This looks good. It just needs a few unit tests.
| @FormParams(keys = ACTION, values = "ReleaseAddress") | ||
| void releaseAddressInRegionByAllocationId( | ||
| @EndpointParam(parser = RegionToEndpointOrProviderIfNull.class) @Nullable String region, | ||
| @FormParam("AllocationId") String allocationId); |
Member
There was a problem hiding this comment.
Can you please add the corresponding unit test to the ElasticIPAddressApiTest?
| @Fallback(Fallbacks.EmptyFluentIterableOnNotFoundOr404.class) | ||
| FluentIterable<RouteTable> describeRouteTablesWithFilter( | ||
| @EndpointParam(parser = RegionToEndpointOrProviderIfNull.class) @Nullable String region, | ||
| @BinderParam(BindFiltersToIndexedFormParams.class) Multimap<String, String> filter); |
Member
There was a problem hiding this comment.
Can you please add the corresponding unit tests to the RouteTableApiMockTest?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello JClouds! My first pull request. Wanted to try and get this in as I saw activity picking up on the project recently.
The PublicIPInstanceIdPair was missing the "allocationId" attribute and I had a need for that for tracking purposes.
The RouteTable object lacked a method for searching "WithFilter" which I had a need for. Tried to follow the projects existing pattern for this sort of thing.
Cheers!