JCLOUDS-1644: Create AWS S3 buckets with ownership and public access …

…block AWS changed the defaults when creating buckets to prevent public-read and other canned ACLs. Background: https://stackoverflow.com/a/76102067/2800111
apache · Jan 22, 2025 · 26338e3 · 26338e3
1 parent dd6cb51
commit 26338e3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/apis/s3/src/test/java/org/jclouds/s3/S3ClientLiveTest.java b/apis/s3/src/test/java/org/jclouds/s3/S3ClientLiveTest.java
@@ -147,6 +147,8 @@ protected URL getObjectURL(String containerName, String key) throws Exception {
    public void testPutCannedAccessPolicyPublic() throws Exception {
       String containerName = getContainerName();
       try {
+         allowPublicReadable(containerName);
+
          String key = "hello";
          S3Object object = getApi().newS3Object();
          object.getMetadata().setKey(key);
@@ -236,6 +238,8 @@ public void run() {
    public void testUpdateObjectACL() throws InterruptedException, ExecutionException, TimeoutException, IOException {
       String containerName = getContainerName();
       try {
+         allowPublicReadable(containerName);
+
          String objectKey = "private-acl";
 
          // Private object

diff --git a/apis/s3/src/test/java/org/jclouds/s3/services/BucketsLiveTest.java b/apis/s3/src/test/java/org/jclouds/s3/services/BucketsLiveTest.java
@@ -118,6 +118,7 @@ public void testUpdateBucketACL() throws InterruptedException, ExecutionExceptio
          assertEquals(acl.getGrants().size(), 1);
          assertTrue(acl.hasPermission(ownerId, FULL_CONTROL));
 
+         allowPublicReadable(bucketName);
          addGrantsToACL(acl);
          assertEquals(acl.getGrants().size(), 4);
          assertTrue(getApi().putBucketACL(bucketName, acl));