Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAK-11269 Commit Message Check #1913

Merged
merged 2 commits into from
Jan 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions .commit-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements. See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# format as outlined in https://github.com/commit-check/commit-check/blob/main/.commit-check.yml
# further information in https://github.com/commit-check/commit-check/blob/main/README.rst
checks:
- check: message
regex: '^OAK-\d+\s\S+.*'
error: "The commit message must start with 'OAK-<ID> ' followed by some descriptive text"
suggest: Please check your commit message whether it matches above regex

- check: author_name
regex: ^[A-Za-z ,.\'-]+$|.*(\[bot])
error: The committer name seems invalid
suggest: run command `git config user.name "Your Name"`

- check: author_email
regex: ^.+@.+$
error: The committer email seems invalid
suggest: run command `git config user.email [email protected]`
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ~ Licensed to the Apache Software Foundation (ASF) under one
# ~ Licensed to the Apache Software Foundation (ASF) under one
# ~ or more contributor license agreements. See the NOTICE file
# ~ distributed with this work for additional information
# ~ regarding copyright ownership. The ASF licenses this file
Expand Down
49 changes: 49 additions & 0 deletions .github/workflows/commit-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# ~ Licensed to the Apache Software Foundation (ASF) under one
# ~ or more contributor license agreements. See the NOTICE file
# ~ distributed with this work for additional information
# ~ regarding copyright ownership. The ASF licenses this file
# ~ to you under the Apache License, Version 2.0 (the
# ~ "License"); you may not use this file except in compliance
# ~ with the License. You may obtain a copy of the License at
# ~
# ~ http://www.apache.org/licenses/LICENSE-2.0
# ~
# ~ Unless required by applicable law or agreed to in writing,
# ~ software distributed under the License is distributed on an
# ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# ~ KIND, either express or implied. See the License for the
# ~ specific language governing permissions and limitations
# ~ under the License.

name: Commit Check

on:
pull_request:
branches: 'trunk'

jobs:
commit-check:
runs-on: ubuntu-latest
permissions: # use permissions because of use pr-comments
contents: read
pull-requests: write
steps:
- uses: actions/checkout@v4
with:
ref: ${{ github.event.pull_request.head.sha }} # checkout PR HEAD commit
fetch-depth: 0 # required for merge-base check
# https://github.com/commit-check
# must be pinned due to https://infra.apache.org/github-actions-policy.html
- uses: commit-check/commit-check-action@8d507e12899a9feb405c3ed546252ff9508724e0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # use GITHUB_TOKEN because of use pr-comments
with:
# check commit message formatting convention
message: true
branch: true
author-name: true
author-email: true
commit-signoff: false
merge-base: false
job-summary: true
pr-comments: ${{ github.event_name == 'pull_request' }}
2 changes: 1 addition & 1 deletion .github/workflows/stale.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# ~ Licensed to the Apache Software Foundation (ASF) under one
# ~ Licensed to the Apache Software Foundation (ASF) under one
# ~ or more contributor license agreements. See the NOTICE file
# ~ distributed with this work for additional information
# ~ regarding copyright ownership. The ASF licenses this file
Expand Down
Loading