OAK-8413 Use the new Azure SDK in the Azure Segment Store #1748

ierandra · 2024-09-27T12:34:08Z

No description provided.

…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopy.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentStoreServiceTest.java

dulceanu · 2024-09-30T10:45:25Z

@ierandra, the build fails with the following error in Oak Segment Azure:
[ERROR] org.apache.jackrabbit.oak.segment.azure: Version increase required; detected 3.0.0, suggested 4.0.0 [ERROR] org.apache.jackrabbit.oak.segment.azure.util: Version increase required; detected 1.71.0, suggested 2.0.0

ierandra · 2024-09-30T12:07:49Z

@dulceanu I was using -Dbaseline.skip in the build command.
Please let me know if I should update the versions so that we don't get these messages.

dulceanu · 2024-09-30T12:55:02Z

@ierandra, yes, the versions need to be updated so that the build passes without skipping the baseline check.

… package versions

dulceanu · 2024-10-01T09:21:51Z

Now oak-segment-azure build fails when issuing mvn clean install with lots of test related setup preconditions not met. Could you see what's this about, please?

… fixes

ierandra · 2024-10-02T10:11:49Z

@dulceanu I fixed all the tests. build should be ok now.

reschke · 2024-10-29T14:52:18Z

This doesn't seem to compile (after applying the diff to oak trunk):

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.10.1:compile (default-compile) on project oak-segment-azure: Compilation failure: Compilation failure:
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[43,47] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManager
[ERROR]   location: package org.apache.jackrabbit.oak.segment.azure
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[134,88] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManagerV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[163,76] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManagerV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[169,63] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManagerV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[54,19] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[56,19] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[64,22] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[64,67] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[72,29] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[72,74] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[105,18] cannot find symbol
[ERROR]   symbol:   class BlobItem
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[121,23] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.AzureJournalReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[123,23] cannot find symbol
[ERROR]   symbol:   class BlobItem
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.AzureJournalReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[131,36] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.AzureJournalReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[131,77] cannot find symbol
[ERROR]   symbol:   class BlobItem
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.AzureJournalReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[166,17] cannot find symbol
[ERROR]   symbol:   class AppendBlobClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.AzureJournalWriter
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[287,32] cannot find symbol
[ERROR]   symbol:   class BlobContainerClient
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.CombinedReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[287,78] cannot find symbol
[ERROR]   symbol:   class BlobItem
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile.CombinedReader
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java:[62,21] cannot find symbol
[ERROR]   symbol:   class CloudBlobDirectory
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java:[69,32] cannot find symbol
[ERROR]   symbol:   class CloudBlobDirectory
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[141,35] cannot find symbol
[ERROR]   symbol:   class AzurePersistenceV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[185,20] cannot find symbol
[ERROR]   symbol:   variable AzureUtilitiesV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[193,14] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManagerV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java:[193,84] cannot find symbol
[ERROR]   symbol:   class AzureStorageCredentialManagerV8
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.tool.ToolUtils
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistence.java:[68,16] constructor AzureArchiveManager in class org.apache.jackrabbit.oak.segment.azure.AzureArchiveManager cannot be applied to given types;
[ERROR]   required: CloudBlobDirectory,org.apache.jackrabbit.oak.segment.spi.monitor.IOMonitor,org.apache.jackrabbit.oak.segment.spi.monitor.FileStoreMonitor,org.apache.jackrabbit.oak.segment.remote.WriteAccessController
[ERROR]   found: com.azure.storage.blob.BlobContainerClient,com.azure.storage.blob.BlobContainerClient,java.lang.String,org.apache.jackrabbit.oak.segment.spi.monitor.IOMonitor,org.apache.jackrabbit.oak.segment.spi.monitor.FileStoreMonitor,org.apache.jackrabbit.oak.segment.remote.WriteAccessController
[ERROR]   reason: actual and formal argument lists differ in length
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[107,13] cannot find symbol
[ERROR]   symbol:   class ListBlobsOptions
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[107,53] cannot find symbol
[ERROR]   symbol:   class ListBlobsOptions
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[109,18] cannot find symbol
[ERROR]   symbol:   class BlobItem
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile
[ERROR] /C:/projects/apache/oak/trunk/oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java:[110,87] cannot find symbol
[ERROR]   symbol:   variable BlobType
[ERROR]   location: class org.apache.jackrabbit.oak.segment.azure.AzureJournalFile

...etc...

reschke

See #1748 (comment)

…bug logging

…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureArchiveManager.java # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureJournalFile.java # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/ToolUtils.java

… fixes

ierandra · 2024-10-29T15:33:53Z

@reschke I updated the PR with changes from apache/jackrabbit-oak trunk and should be fine now

reschke · 2024-10-29T18:02:18Z

It does indeed; thanks.

reschke · 2024-10-29T18:06:17Z

This looks a bit weird:

[WARNING] com.azure.core.credential: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] com.azure.core.credential: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] com.azure.identity: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] com.azure.identity: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage.blob: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage.blob: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage.core: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] com.microsoft.azure.storage.core: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.counters: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.counters: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.maps: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.maps: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.atomic: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.atomic: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.atomic.unpadded: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.atomic.unpadded: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.unpadded: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.queues.unpadded: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.util: Excessive version increase; detected 1.71.0, suggested 1.70.0
[WARNING] io.netty.util.internal.shaded.org.jctools.util: Version has been increased but analysis detected no changes; detected 1.71.0, suggested 1.70.0

are we exporting these packages?

This looks wrong...:

                        <Export-Package>
                            org.apache.jackrabbit.oak.segment.azure,
                            org.apache.jackrabbit.oak.segment.azure.queue,
                            org.apache.jackrabbit.oak.segment.azure.util,
                            com.fasterxml.jackson.dataformat.xml,
                            com.fasterxml.jackson.dataformat.xml.deser,
                            com.microsoft.azure.storage,
                            com.microsoft.azure.storage.core,
                            com.microsoft.azure.storage.blob,
                            com.azure.core.credential,
                            com.azure.identity,
                            com.azure.blob,
                            com.azure.storage.common,
                            com.azure.storage.internal.avro.implementation
                        </Export-Package>

reschke · 2024-10-29T18:11:10Z

oak-segment-azure/pom.xml

                        </Export-Package>
                        <Embed-Dependency>
                            azure-storage,
                            azure-keyvault-core,
                            azure-core,
                            azure-identity,
                            azure-json,
+                            azure-xml,


Arer we embedding the new SDK? Why?

(We embedded the old one due to the Guava dependency issue, but this should not be needed here)

I tried without and I got the following error at build:
[ERROR] Bundle oak-segment-azure:1.71-ierandra-T20241104112150-3ccdb109e0 is importing package(s) com.azure.xml in start level 15 but no bundle is exporting these for that start level.

In the oak-it-osgi tests? In which case we may have to add the dependency there.

no, when building CQ: https://jenkins-evergreen.ci.corp.adobe.com/job/Sprouts/job/aemcs-developer-releases/5335/artifact/1-BuildAEM.log

reschke · 2024-10-29T19:10:54Z

Opened https://issues.apache.org/jira/browse/OAK-11236 - the embedding/exporting issues started earlier.

…refix and missing metadata

…refix issue

reschke

As this adds many new files, please make sure that all of them just use LF as line ends (otherwise fixing this will cause ugly diffs), and check with "-Prat" that all licenses are ok.

oak-parent/pom.xml

oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/package-info.java

smiroslav · 2024-11-12T09:05:04Z

The build on my machine fails because of baseline plugin

$ mvn clean install -DskipTests
....
[ERROR] org.apache.jackrabbit.oak.segment.azure.util: Version increase required; detected 1.0.0, suggested 2.0.0

[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  39.965 s
[INFO] Finished at: 2024-11-12T10:02:29+01:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.felix:maven-bundle-plugin:5.1.9:baseline (baseline) on project oak-segment-azure: Baseline failed, see generated report -> [Help 1]
[

…refix issue

ierandra · 2024-11-12T10:18:04Z

@smiroslav I configure it back to 2.0.0. should work now

...ure/src/main/java/org/apache/jackrabbit/oak/segment/azure/v8/AzureSegmentStoreServiceV8.java

...ent-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzurePersistenceManager.java

...ure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureHttpRequestLoggingPolicy.java

smiroslav · 2024-11-12T13:54:29Z

...segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java

-                    requestOptions.setMaximumExecutionTimeInMs(LEASE_RENEWAL_TIMEOUT_MS);
-                    requestOptions.setRetryPolicyFactory(new RetryNoRetry());
-                    blob.renewLease(AccessCondition.generateLeaseCondition(leaseId), requestOptions, null);
+                    leaseId = leaseClient.renewLeaseWithResponse((RequestConditions) null, Duration.ofMillis(LEASE_RENEWAL_TIMEOUT_MS), Context.NONE).getValue();


The previous implementation configured request options with RetryNoRetry.
How is it achieved here?

based on what I looked the solution is to add a 3rd azure connection only for the lease.

Fixed.
Please see here and here

...segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java

oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/tool/AzureCheck.java

...nt-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java

smiroslav · 2024-11-13T16:10:20Z

...nt-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java

+        return new RequestRetryOptions(RetryPolicyType.EXPONENTIAL,
+                retryAttempts,
+                timeoutExecution,
+                timeoutIntervalToMs,


the intent of TIMEOUT_INTERVAL_PROP was to specify max execution time for one retry

From the Java documentation

Sets the timeout to use when making this request. The server timeout interval begins at the time that the complete request has been received by the service, and the server begins processing the response. If the timeout interval elapses before the response is returned to the client, the operation times out. The timeout interval resets with each retry, if the request is retried.

You can check the intent of the properties in the linked below nad map it to the corresponding ones in v12

https://github.com/Azure/azure-storage-java/blob/v8.6.6/microsoft-azure-storage/src/com/microsoft/azure/storage/RequestOptions.java#L266

timeoutIntervalToMs should be the third argument.
https://learn.microsoft.com/en-us/java/api/com.azure.storage.common.policy.requestretryoptions?view=azure-java-stable#com-azure-storage-common-policy-requestretryoptions-requestretryoptions(com-azure-storage-common-policy-retrypolicytype-java-lang-integer-java-lang-integer-java-lang-long-java-lang-long-java-lang-string)

I changed them. Should be fine now.

...ure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriterTest.java

...gment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/MockAzureHttpResponse.java

smiroslav · 2024-11-18T12:39:26Z

@ierandra, I would prefer if you let me resolve the PR comments that I have started.
This post captures well the resoninig I have in mind
https://www.danclarke.com/resolving-pr-comments

smiroslav · 2024-11-19T14:01:01Z

...nt-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/AzureRequestOptions.java

+        return getRetryOptionsDefault(null);
+    }
+
+    public static RequestRetryOptions getRetryOptionsDefault(String secondaryHost) {


I suggest checking doc for SDK v12
https://learn.microsoft.com/en-us/java/api/com.azure.storage.common.policy.requestretryoptions?view=azure-java-stable#com-azure-storage-common-policy-requestretryoptions-requestretryoptions(com-azure-storage-common-policy-retrypolicytype-java-lang-integer-java-lang-integer-java-lang-long-java-lang-long-java-lang-string)

Some system properties can be reused, and those which can not should be deleted.

could you please be more specific. now sure what to check.

From the API RequestRetryOptions constructor has the following arguments:

retryPolicyType - this one should be RetryPolicyType.FIXED ✅

maxTries - this should come from RETRY_ATTEMPTS_PROP ("segment.azure.retry.attempts") ✅

tryTimeoutInSeconds - this would be max timeout for one retry, initialised with TIMEOUT_INTERVAL_PROP ("segment.timeout.interval") ❌ currently in the code it takes value from TIMEOUT_EXECUTION_PROP

retryDelayInMs - should come from RETRY_BACKOFF_PROP ("segment.azure.retry.backoff") ✅

maxRetryDelayInMs - probably the same value as for retryDelayInMs can be used

Unused system properties should be deleted from AzureRequestOptions

This link explains retry options in detail
https://learn.microsoft.com/en-us/azure/storage/blobs/storage-retry-policy-java

…to issue/OAK-8413 # Conflicts: # oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/AzureRepositoryLock.java # oak-segment-azure/src/test/java/org/apache/jackrabbit/oak/segment/azure/tool/SegmentCopyAzureServicePrincipalToTarTest.java

reschke

I'm only looking into POMs here.

It is unclear why apparently apparently all new dependencies get embedded. What's the reason for that?

ierandra · 2024-11-26T10:17:50Z

@reschke

I'm only looking into POMs here.
It is unclear why apparently apparently all new dependencies get embedded. What's the reason for that?

As I mention in my previous comment if I don't do it if fails at build phase for CQ:
https://jenkins-evergreen.ci.corp.adobe.com/job/Sprouts/job/aemcs-developer-releases/5335/artifact/1-BuildAEM.log

ierandra · 2024-11-27T10:01:33Z

@smiroslav I fixed all the comments. could you please take a look?

smiroslav · 2024-12-06T16:38:23Z

Thanks @ierandra I am having a look.

In the meantime, I started the build, and it failed.
A bunch of test are failing on my local machine as well when I run

mvn test -pl oak-segment-azure

[ERROR] testInitialSize(org.apache.jackrabbit.oak.segment.azure.AzureTarFilesTest)  Time elapsed: 0 s  <<< ERROR!
java.lang.IllegalArgumentException: The value of the parameter 'maxRetries' should be between 1 and 2147483647.
        at com.azure.storage.common.implementation.StorageImplUtils.assertInBounds(StorageImplUtils.java:192)
        at com.azure.storage.common.policy.RequestRetryOptions.<init>(RequestRetryOptions.java:98)
        at com.azure.storage.common.policy.RequestRetryOptions.<init>(RequestRetryOptions.java:64)

ierandra · 2024-12-16T13:18:57Z

@smiroslav I just run the command you mentioned (mvn test -pl oak-segment-azure) and the build was with success. Please make sure you git-fetch-pull the latest changes.

smiroslav · 2024-12-17T10:09:25Z

@ierandra the build first failed in jenkins
https://github.com/apache/jackrabbit-oak/actions/runs/12028412044/job/34038518960?pr=1748

smiroslav · 2024-12-18T15:26:30Z

https://github.com/apache/jackrabbit-oak/actions/runs/12028412044/job/34597299155?pr=1748

Error:  deactivate(org.apache.jackrabbit.oak.segment.azure.AzureSegmentStoreServiceTest)  Time elapsed: 0.006 s  <<< ERROR!
java.lang.IllegalArgumentException: The value of the parameter 'maxRetries' should be between 1 and 2147483647.
	at com.azure.storage.common.implementation.StorageImplUtils.assertInBounds(StorageImplUtils.java:192)
	at com.azure.storage.common.policy.RequestRetryOptions.<init>(RequestRetryOptions.java:98)
	at com.azure.storage.common.policy.RequestRetryOptions.<init>(RequestRetryOptions.java:64)
	at org.apache.jackrabbit.oak.segment.azure.util.AzureRequestOptions.getRetryOptionsDefault(AzureRequestOptions.java:56)
	at org.apache.jackrabbit.oak.segment.azure.util.AzureRequestOptions.getRetryOptionsDefault(AzureRequestOptions.java:43)
	at org.apache.jackrabbit.oak.segment.azure.AzuriteDockerRule.getReadBlobContainerClient(AzuriteDockerRule.java:104)
	at org.apache.jackrabbit.oak.segment.azure.AzureSegmentStoreServiceTest.setup(AzureSegmentStoreServiceTest.java:85)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

…to issue/OAK-8413

ierandra added 2 commits September 27, 2024 18:30

OAK-8413 Use the new Azure SDK in the Azure Segment Store

7e3dfc0

dulceanu requested review from dulceanu and smiroslav September 27, 2024 12:37

OAK-8413 Use the new Azure SDK in the Azure Segment Store - configure…

75edd07

… package versions

dulceanu requested a review from reschke October 1, 2024 08:59

ierandra added 3 commits October 1, 2024 19:33

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review…

2768330

… fixes

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests

f98b20b

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests

9718bbc

reschke requested changes Oct 29, 2024

View reviewed changes

ierandra added 3 commits October 29, 2024 17:06

OAK-8413 Use the new Azure SDK in the Azure Segment Store - remove de…

a125e1e

…bug logging

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review…

43df254

… fixes

ierandra requested a review from reschke October 29, 2024 15:34

reschke requested changes Oct 29, 2024

View reviewed changes

ierandra added 2 commits November 1, 2024 16:14

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…

045b4dd

…refix and missing metadata

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…

3ccdb10

…refix issue

reschke reviewed Nov 1, 2024

View reviewed changes

oak-parent/pom.xml Outdated Show resolved Hide resolved

oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/util/package-info.java Show resolved Hide resolved

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review

427ca79

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix rootP…

a33dd37

…refix issue

smiroslav reviewed Nov 12, 2024

View reviewed changes

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review

931cc3b

smiroslav reviewed Nov 13, 2024

View reviewed changes

...ure/src/test/java/org/apache/jackrabbit/oak/segment/azure/AzureSegmentArchiveWriterTest.java Outdated Show resolved Hide resolved

smiroslav reviewed Nov 13, 2024

View reviewed changes

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review

6374860

smiroslav reviewed Nov 19, 2024

View reviewed changes

ierandra added 3 commits November 20, 2024 12:19

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review

12c5eae

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge

84180d8

ierandra requested review from smiroslav and reschke November 21, 2024 11:22

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR merge

871294b

reschke requested changes Nov 22, 2024

View reviewed changes

OAK-8413 Use the new Azure SDK in the Azure Segment Store - PR review

d236a3c

ierandra requested a review from reschke November 28, 2024 08:18

ierandra added 3 commits December 19, 2024 11:07

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests

6d5da69

Merge branch 'trunk' of https://github.com/ierandra/jackrabbit-oak in…

d038384

…to issue/OAK-8413

OAK-8413 Use the new Azure SDK in the Azure Segment Store - fix tests

bf3b7cc

OAK-8413 Use the new Azure SDK in the Azure Segment Store #1748

Are you sure you want to change the base?

OAK-8413 Use the new Azure SDK in the Azure Segment Store #1748

Conversation

ierandra commented Sep 27, 2024

dulceanu commented Sep 30, 2024

ierandra commented Sep 30, 2024

dulceanu commented Sep 30, 2024

dulceanu commented Oct 1, 2024

ierandra commented Oct 2, 2024

reschke commented Oct 29, 2024 • edited Loading

reschke left a comment

Choose a reason for hiding this comment

ierandra commented Oct 29, 2024

reschke commented Oct 29, 2024

reschke commented Oct 29, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reschke commented Oct 29, 2024

reschke left a comment

Choose a reason for hiding this comment

smiroslav commented Nov 12, 2024

ierandra commented Nov 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smiroslav Nov 13, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

smiroslav commented Nov 18, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

reschke left a comment

Choose a reason for hiding this comment

ierandra commented Nov 26, 2024

ierandra commented Nov 27, 2024

smiroslav commented Dec 6, 2024 • edited Loading

ierandra commented Dec 16, 2024

smiroslav commented Dec 17, 2024

smiroslav commented Dec 18, 2024

reschke commented Oct 29, 2024 •

edited

Loading

reschke commented Oct 29, 2024 •

edited

Loading

smiroslav Nov 13, 2024 •

edited

Loading

smiroslav commented Dec 6, 2024 •

edited

Loading