Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
org.apache.iotdb.db.metadata.MetaUtilsTest#testParseDeadbandInfo
fails under NonDex tool which detects non-deterministic nature of tests with when non-deterministic data structures are used. The failure is because of hashmap.toString() being compared directly and hashmap doesn't gurantee ordering.How to Reproduce
mvn -pl iotdb-core/datanode edu.illinois:nondex-maven-plugin:2.1.7:nondex
-Dtest=MetaUtilsTest#testParseDeadbandInfo
-DnondexRuns=10
Error
[ERROR] org.apache.iotdb.db.metadata.MetaUtilsTest.testParseDeadbandInfo -- Time elapsed: 1.257 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<{comp[mintime=2, compmaxtime=10, compdev=0.01]}> but was:<{comp[dev=0.01, compmintime=2, compmaxtime=10]}>
at org.junit.Assert.assertEquals(Assert.java:117)
at org.junit.Assert.assertEquals(Assert.java:146)
at org.apache.iotdb.db.metadata.MetaUtilsTest.testParseDeadbandInfo(MetaUtilsTest.java:194) ...
Proposed Solution
Implement parseHashmap method to parse the string and convert it into hashmap, and then compare it with the expected hashmap.
Please let me know if you have any questions or need any additional justification/changes from my side.
This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR