[INLONG-10832][SDK] Transform SQL support Translate function #10863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @lianghuan-xatu, thank you for submitting a PR to InLong 💖 We will respond as soon as possible ⏳
This seems to be your first PR 🌠 Please be sure to follow our Contribution Guidelines.
If you have any questions in the meantime, you can also ask us on the InLong Discussions 🔍
yfsn666
reviewed
Aug 25, 2024
| int replaceSize = replaceChars == null ? 0 : replaceChars.length(); | ||
| for (int i = 0, size = originalStr.length(); i < size; i++) { | ||
| char ch = originalStr.charAt(i); | ||
| int index = findChars.indexOf(ch); |
There was a problem hiding this comment.
It is better to create a Map in advance to map the relationship between the find character and the replace character to avoid calling the indexOf function in the for loop. The time complexity of the indexOf function is O(n)
aloyszhang
reviewed
Aug 26, 2024
...rm-sdk/src/main/java/org/apache/inlong/sdk/transform/process/function/TranslateFunction.java
Show resolved
Hide resolved
aloyszhang
previously approved these changes
Aug 27, 2024
yfsn666
approved these changes
Aug 27, 2024
vernedeng
reviewed
Aug 27, 2024
...test/java/org/apache/inlong/sdk/transform/process/TestTransformStringFunctionsProcessor.java
Show resolved
Hide resolved
lianghuan-xatu
force-pushed
the
transform-function-translate
branch
from
088185b to
8a60287
Compare
lianghuan-xatu
force-pushed
the
transform-function-translate
branch
from
8a60287 to
2bb75be
Compare
vernedeng
previously approved these changes
Aug 28, 2024
aloyszhang
approved these changes
Aug 28, 2024
vernedeng
approved these changes
Aug 28, 2024
yfsn666
approved these changes
Aug 28, 2024
MOONSakura0614
pushed a commit
to MOONSakura0614/inlong
that referenced
this pull request
Sep 3, 2024
…10863) Co-authored-by: AloysZhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #10832
Motivation
translate(originalString, searchString, replacementString)
translate function that replaces a sequence of characters in a string with another set of characters.
Example:
case1: translate("hello word!", "el", "EL")
case2: translate('ApaCHe Inlong', CH, ch)
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework/code cleanup without any test coverage.
This change is already covered by existing tests, such as:
(please describe tests)
This change added tests and can be verified as follows:
(example:)
Documentation