Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kie-issues#1769 [kn-workflow-plugin] Specify image on 'workflow run' #2895

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

kie-issues#1769 [kn-workflow-plugin] Specify image on 'workflow run' #2895

wants to merge 1 commit into from
+11 −1

Conversation

treblereel
Copy link
Contributor

@treblereel treblereel commented Feb 4, 2025 •
edited by yesamer
Loading

@treblereel treblereel self-assigned this Feb 4, 2025
@treblereel treblereel changed the title kie-issues#1769 [kn-workflow-plugin] Specify image on 'workflow deploy' kie-issues#1769 [kn-workflow-plugin] Specify image on 'workflow run' Feb 4, 2025
domhanak
domhanak reviewed Feb 4, 2025
View reviewed changes
packages/kn-plugin-workflow/pkg/command/run.go
@@ -65,9 +66,12 @@ func NewRunCommand() *cobra.Command {
# Stop the container when the user presses any key
{{.Name}} run --stop-container-on-user-input=false

# Specify a custom container image to use for the deployment.
{{.Name}} run --image=<your_image>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we add something like By default, the apache-kie-sonataflow-devmode image is used Just to be more clear what image are users substituting.

domhanak
domhanak requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@domhanak domhanak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@treblereel the image as flag is little bit confusing imho. Not sure how to improve it thought, container_image seems confusing too to me.

Also I am missing unit test for this change. From Integration Test perspective I think it is fine for now.

@ricardozanini
Copy link
Member

@treblereel the image as flag is little bit confusing imho. Not sure how to improve it thought, container_image seems confusing too to me.

@domhanak wdym? The --image flag is to replace the runner image with a custom one for debug/patches or any other reasons a user would need to change the base image to run with CLI.

If not --image, which name would you propose?

@domhanak
Copy link
Contributor

domhanak commented Feb 4, 2025

I think we could improve the help text with what you said and it should be ok. Most probably better solvable by providing a good guide for the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domhanak domhanak domhanak requested changes

@tiagobento tiagobento Awaiting requested review from tiagobento tiagobento is a code owner

@ricardozanini ricardozanini Awaiting requested review from ricardozanini

Requested changes must be addressed to merge this pull request.

Assignees

@treblereel treblereel

Labels
area:sonataflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[kn-plugin-workflow] Specify image on 'workflow run'
3 participants
@treblereel @ricardozanini @domhanak