Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kogito-2195] Kogito Examples Ansible automation for CRC #509

Closed
wants to merge 1 commit into from

Conversation

desmax74
Copy link
Contributor

@desmax74 desmax74 commented May 15, 2020

@desmax74 desmax74 changed the title [Kogito-2195] Kogito Ansible automation for CRC [Kogito-2195] Kogito Examples Ansible automation for CRC May 15, 2020
The [Kogito Examples repository](https://github.com/kiegroup/kogito-examples) module contains a number of examples that you can take a look at and try out yourself.
The [Kogito Examples repository](https://github.com/kiegroup/kogito-examples) module contains a number of examples that you can take a look at and try out yourself or
deploy examples on Openshift (CRC) with Ansible [README.md](https://github.com/kiegroup/kie-docs/tree/master/doc-content/kogito-ansible-docs/README.md)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desmax74 , I've flagged this Do not merge because I think there's some confusion. What you submitted in your docs PR is actually what you should add to the Kogito examples repo. Meaning, at the bottom of the Kogito examples repo README, after the "Trying the examples with the Operator", add the relevant sections about running the Kogito examples using Ansible. Then include the playbooks in that examples repo.

Then in this repo, can just mention it like you have in this README, but refer to that README in that examples repo.

Then in the docs repo, you can create PR to actually add content to the Kogito docs as instructed in the master-kogito branch README instructions. Right now, your docs PR doesn't actually contribute to the Kogito documentation, it just creates its own README with resources. I suggest adding a subsection called "Deploying the Kogito example applications on OpenShift using Ansible playbooks" after "Running the Kogito example applications". Then after you submit your docs PR, I can work through it to make it ready for both community and enterprise (when the time comes). I may do this in your actual PR or just have you merge and then I work through it separately.

Does this make sense? If you want to simplify, just focus on getting the content into the Kogito examples repo as I've explained, then once that's in place, I can update the docs based on your examples content and README update in the examples repo to update the Kogito docs myself and put you as my SME reviewer so you can see for future reference.

Let me know what you think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@desmax74
Copy link
Contributor Author

@sterobin closing this PR replaced by kiegroup/kogito-examples#258

@desmax74 desmax74 closed this May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants