[Incubator kie issues#1743]Return a list of dates instead of a range #6223

AthiraHari77 · 2025-01-20T08:54:49Z

This PR resolves the issue in DMN TCK where ranges were not being evaluated correctly. With this fix, ranges are now evaluated properly, and a list of dates is returned instead of a range.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request and downstream checks
- Push a new commit to the PR. An empty commit would be enough.
for a full downstream build
- for github actions job: add the label run_fdb
for Jenkins PR check only
- If you are an ASF committer for KIE podling, login to Jenkins (https://ci-builds.apache.org/job/KIE/job/drools/), go to the specific PR job, and click on Build Now button.

gitgabrio

Thanks @AthiraHari77 LGTM! 👍

pibizza · 2025-01-20T09:58:25Z

...el/src/test/java/org/kie/dmn/feel/lang/ast/forexpressioniterators/ForIterationUtilsTest.java

+        ForIteration actualResult = getForIteration(range, "rangeTest", ctx);
+        assertThat(actualResult).isNotNull();
+        assertEquals(actualResult.toString(), expectedResult.toString());


Please do not use assertEquals. Assertj assertions are standard inside drools code.

Fixed, updated the testcases.

kie-ci3 · 2025-01-20T14:01:03Z

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #6223 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-6223/3/display/redirect

Test results:

PASSED: 22778
FAILED: 7

Those are the test failures:

org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtilsTest.getForIterationNotValidTest

Expecting actual throwable to be an instance of:
org.kie.dmn.feel.exceptions.EndpointOfRangeNotValidTypeException
but was:
org.kie.dmn.feel.exceptions.EndpointOfForIterationNotValidTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.valueMustBeValid(ForIterationUtils.java:62)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:55)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.getForIteration(ForIterationUtils.java:37)
...(74 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)

org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtilsTest.validateValuesFalseTest

Expecting actual throwable to be an instance of:
org.kie.dmn.feel.exceptions.EndpointOfRangeNotValidTypeException
but was:
org.kie.dmn.feel.exceptions.EndpointOfForIterationNotValidTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.valueMustBeValid(ForIterationUtils.java:62)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:55)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtilsTest.validateValuesFalseTest(ForIterationUtilsTest.java:127)
...(73 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)

org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtilsTest.valueMustBeValidFalseTest

Expecting actual throwable to be an instance of:
org.kie.dmn.feel.exceptions.EndpointOfRangeNotValidTypeException
but was:
org.kie.dmn.feel.exceptions.EndpointOfForIterationNotValidTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.valueMustBeValid(ForIterationUtils.java:62)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtilsTest.valueMustBeValidFalseTest(ForIterationUtilsTest.java:108)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
...(72 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)

org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(String, Object, Severity, FEEL_TARGET, Boolean, FEELDialect)[9]

org.kie.dmn.feel.exceptions.EndpointOfForIterationDifferentTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:53)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.getForIteration(ForIterationUtils.java:37)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.createForIteration(ForExpressionNode.java:146)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.populateToReturn(ForExpressionNode.java:103)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.evaluate(ForExpressionNode.java:85)
at org.kie.dmn.feel.lang.impl.CompiledExpressionImpl.apply(CompiledExpressionImpl.java:49)
at org.kie.dmn.feel.lang.impl.InterpretedExecutableExpression.apply(InterpretedExecutableExpression.java:40)
at org.kie.dmn.feel.lang.impl.InterpretedExecutableExpression.apply(InterpretedExecutableExpression.java:26)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:96)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:39)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:156)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:148)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:124)
at org.kie.dmn.feel.runtime.BaseFEELTest.assertResult(BaseFEELTest.java:89)
at org.kie.dmn.feel.runtime.BaseFEELTest.expression(BaseFEELTest.java:74)
at org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(FEEL12ExtendedForLoopTest.java:45)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(String, Object, Severity, FEEL_TARGET, Boolean, FEELDialect)[10]

org.kie.dmn.feel.exceptions.EndpointOfForIterationDifferentTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:53)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.getForIteration(ForIterationUtils.java:37)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.createForIteration(ForExpressionNode.java:146)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.populateToReturn(ForExpressionNode.java:103)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.evaluate(ForExpressionNode.java:85)
at org.kie.dmn.feel.codegen.feel11.gen902e779e9b4f422495f4844979c88e4d.TemplateCompiledFEELExpression.apply(TemplateCompiledFEELExpression.java:36)
at org.kie.dmn.feel.codegen.feel11.gen902e779e9b4f422495f4844979c88e4d.TemplateCompiledFEELExpression.apply(TemplateCompiledFEELExpression.java:26)
at org.kie.dmn.feel.lang.impl.CompiledExecutableExpression.apply(CompiledExecutableExpression.java:34)
at org.kie.dmn.feel.lang.impl.CompiledExecutableExpression.apply(CompiledExecutableExpression.java:24)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:96)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:39)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:156)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:148)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:124)
at org.kie.dmn.feel.runtime.BaseFEELTest.assertResult(BaseFEELTest.java:89)
at org.kie.dmn.feel.runtime.BaseFEELTest.expression(BaseFEELTest.java:74)
at org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(FEEL12ExtendedForLoopTest.java:45)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(String, Object, Severity, FEEL_TARGET, Boolean, FEELDialect)[21]

org.kie.dmn.feel.exceptions.EndpointOfForIterationDifferentTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:53)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.getForIteration(ForIterationUtils.java:37)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.createForIteration(ForExpressionNode.java:146)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.populateToReturn(ForExpressionNode.java:103)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.evaluate(ForExpressionNode.java:85)
at org.kie.dmn.feel.lang.ast.ContextEntryNode.evaluate(ContextEntryNode.java:70)
at org.kie.dmn.feel.lang.ast.ContextNode.evaluate(ContextNode.java:79)
at org.kie.dmn.feel.lang.impl.CompiledExpressionImpl.apply(CompiledExpressionImpl.java:49)
at org.kie.dmn.feel.lang.impl.InterpretedExecutableExpression.apply(InterpretedExecutableExpression.java:40)
at org.kie.dmn.feel.lang.impl.InterpretedExecutableExpression.apply(InterpretedExecutableExpression.java:26)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:96)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:39)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:156)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:148)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:124)
at org.kie.dmn.feel.runtime.BaseFEELTest.assertResult(BaseFEELTest.java:89)
at org.kie.dmn.feel.runtime.BaseFEELTest.expression(BaseFEELTest.java:74)
at org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(FEEL12ExtendedForLoopTest.java:45)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(String, Object, Severity, FEEL_TARGET, Boolean, FEELDialect)[22]

org.kie.dmn.feel.exceptions.EndpointOfForIterationDifferentTypeException
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.validateValues(ForIterationUtils.java:53)
at org.kie.dmn.feel.lang.ast.forexpressioniterators.ForIterationUtils.getForIteration(ForIterationUtils.java:37)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.createForIteration(ForExpressionNode.java:146)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.populateToReturn(ForExpressionNode.java:103)
at org.kie.dmn.feel.lang.ast.ForExpressionNode.evaluate(ForExpressionNode.java:85)
at org.kie.dmn.feel.lang.ast.ContextEntryNode.evaluate(ContextEntryNode.java:70)
at org.kie.dmn.feel.lang.ast.ContextNode.evaluate(ContextNode.java:79)
at org.kie.dmn.feel.codegen.feel11.gen47b2b88379974214989da35eee190ab4.TemplateCompiledFEELExpression.apply(TemplateCompiledFEELExpression.java:36)
at org.kie.dmn.feel.codegen.feel11.gen47b2b88379974214989da35eee190ab4.TemplateCompiledFEELExpression.apply(TemplateCompiledFEELExpression.java:26)
at org.kie.dmn.feel.lang.impl.CompiledExecutableExpression.apply(CompiledExecutableExpression.java:34)
at org.kie.dmn.feel.lang.impl.CompiledExecutableExpression.apply(CompiledExecutableExpression.java:24)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:96)
at org.kie.dmn.feel.codegen.feel11.ProcessedExpression.apply(ProcessedExpression.java:39)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:156)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:148)
at org.kie.dmn.feel.lang.impl.FEELImpl.evaluate(FEELImpl.java:124)
at org.kie.dmn.feel.runtime.BaseFEELTest.assertResult(BaseFEELTest.java:89)
at org.kie.dmn.feel.runtime.BaseFEELTest.expression(BaseFEELTest.java:74)
at org.kie.dmn.feel.runtime.FEEL12ExtendedForLoopTest.instanceTest(FEEL12ExtendedForLoopTest.java:45)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:276)
at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

…1743 # Conflicts: # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/Range.java # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/impl/RangeImpl.java

yesamer

Thank you @AthiraHari77 !

yesamer · 2025-01-20T15:42:40Z

@AthiraHari77 Unfortunately the CI reported 7 test failures, can you please check it?

…asses

athira and others added 12 commits December 30, 2024 11:19

[incubator-kie-issues-162105] Code fix to return list of dates

31b859d

Merge branch 'apache:main' into incubator-kie-issues-162105

83e37d7

[incubator-kie-issues-162105] WIP

0cefa71

[incubator-kie-issues-162105] WIP

4a190d4

[incubator-kie-issues#1743] Updated test cases

bc073e1

[incubator-kie-issues#1743] Code refactoring

3f68c98

[incubator-kie-issues#1743] Code refactoring

ed53797

[incubator-kie-issues#1743] Code clean up

45a5e23

Merge branch 'apache:main' into incubator-kie-issues#1743

3249330

[incubator-kie-issues#1743] Updated test cases

0360f93

[incubator-kie-issues#1743] Code fixes

2a793c5

[incubator-kie-issues#1743] Code clean up

946114c

gitgabrio marked this pull request as ready for review January 20, 2025 08:56

gitgabrio approved these changes Jan 20, 2025

View reviewed changes

gitgabrio requested review from baldimir and yesamer January 20, 2025 08:57

pibizza reviewed Jan 20, 2025

View reviewed changes

athira added 3 commits January 20, 2025 15:38

[incubator-kie-issues#1743] Fix review comments

419e232

[incubator-kie-issues#1743] Code fix

13efdbf

[incubator-kie-issues#1743] Fix review comments

0cccc08

baldimir approved these changes Jan 20, 2025

View reviewed changes

athira added 2 commits January 20, 2025 19:35

Merge remote-tracking branch 'origin/main' into incubator-kie-issues#…

bde2e16

…1743 # Conflicts: # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/Range.java # kie-dmn/kie-dmn-feel/src/main/java/org/kie/dmn/feel/runtime/impl/RangeImpl.java

[incubator-kie-issues#1743] Fix merge conflicts

97ab953

yesamer approved these changes Jan 20, 2025

View reviewed changes

yesamer added DMN do-not-merge labels Jan 20, 2025

[incubator-kie-issues#1743] Fix broken testcases and remove unused cl…

951afdf

…asses

yesamer merged commit 4478a4c into apache:main Jan 21, 2025
10 checks passed

apache deleted a comment from kie-ci3 Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Incubator kie issues#1743]Return a list of dates instead of a range #6223

[Incubator kie issues#1743]Return a list of dates instead of a range #6223

AthiraHari77 commented Jan 20, 2025

gitgabrio left a comment

pibizza Jan 20, 2025

AthiraHari77 Jan 20, 2025

kie-ci3 commented Jan 20, 2025

yesamer left a comment

yesamer commented Jan 20, 2025 •

edited

Loading

[Incubator kie issues#1743]Return a list of dates instead of a range #6223

[Incubator kie issues#1743]Return a list of dates instead of a range #6223

Conversation

AthiraHari77 commented Jan 20, 2025

gitgabrio left a comment

Choose a reason for hiding this comment

pibizza Jan 20, 2025

Choose a reason for hiding this comment

AthiraHari77 Jan 20, 2025

Choose a reason for hiding this comment

kie-ci3 commented Jan 20, 2025

yesamer left a comment

Choose a reason for hiding this comment

yesamer commented Jan 20, 2025 • edited Loading

yesamer commented Jan 20, 2025 •

edited

Loading