Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues-1601: removing binary files and disabling tests associated with those #6141

Merged
merged 1 commit into from
Nov 3, 2024

Conversation

porcelli
Copy link
Member

@porcelli porcelli commented Nov 2, 2024

Closes: apache/incubator-kie-issues#1601
cleaning up

@porcelli
Copy link
Member Author

porcelli commented Nov 2, 2024

Failures seems unrelated.

Copy link
Contributor

@pibizza pibizza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware that we had to remove also these jars - my understanding was that it was okish since they were test related jars. Anyway approved, we can review this after release of 10.0.0. Thanks for taking care of this.

@porcelli
Copy link
Member Author

porcelli commented Nov 2, 2024

I wasn't expecting that we had to remove, but we got the input that we should remove those as well [1] [2]

[1] https://lists.apache.org/thread/3176kvtgo0o9cljyzsc3dqj6svrxpd21
[2] https://lists.apache.org/thread/q6zp3v3lwxslh0mmydyzlb22r5ght2p8

@porcelli porcelli merged commit 4afd234 into apache:10.0.x Nov 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all binaries (compiled code) from test resources in 10.0.x branch to unblock 10.0.0 release
4 participants