Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1023] DMN - move significant models to test-resources module #5796

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Mar 20, 2024

FIxes apache/incubator-kie-issues#1023

Needed by

apache/incubator-kie-kogito-apps#2022
apache/incubator-kie-kogito-examples#1897

This PR

  1. refactor kie-dmn-test-resources, to separate valid/non valid models and, between them, the 1.5 specific and the older ones
  2. move models used for jitexecutor tests

@tiagobento FYI

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@kie-ci3
Copy link

kie-ci3 commented Mar 20, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5796 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5796/1/display/redirect

Test results:

  • PASSED: 21901
  • FAILED: 20

Those are the test failures:

org.drools.compiler.integrationtests.TimerAndCalendarFireUntilHaltTest.testTimerRuleDoesRestartsIfNoLongerHolds[KieBase type=STREAM_IDENTITY] test timed out after 10000 milliseconds
org.drools.mvel.integrationtests.concurrency.BasicConcurrentInsertionsTest.testConcurrentInsertionsFewObjectsManyThreads[KieBase type=CLOUD_IDENTITY] test timed out after 20000 milliseconds
org.drools.mvel.integrationtests.concurrency.BasicConcurrentInsertionsTest.testConcurrentInsertionsNewSessionEachThreadUpdateFacts[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 20000 milliseconds
org.drools.mvel.integrationtests.concurrency.BasicConcurrentInsertionsTest.testConcurrentInsertionsNewSessionEachThread[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 20000 milliseconds
org.drools.mvel.integrationtests.concurrency.BasicConcurrentInsertionsTest.testConcurrentInsertionsManyObjectsFewThreads[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 20000 milliseconds
org.drools.mvel.integrationtests.concurrency.BasicConcurrentInsertionsTest.testConcurrentInsertionsFewObjectsManyThreads[KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 20000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testMatchingFact[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testNot[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testAccumulatesMatchOnlyOne[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testFunctions2[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testQueries2[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testOneOfAllFactsMatches[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testAccumulatesMatchOnlyBeanA[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testQueries[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentBasesParallelTest.testNotsMatchBoth[Enforced jitting=false, KieBase type=CLOUD_IDENTITY_MODEL_PATTERN] test timed out after 40000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest.testConcurrentInsertionsNewSessionEachThread[DRL=sharedSubnetworkAccumulateRule, KieBase type=CLOUD_IDENTITY] test timed out after 80000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest.testConcurrentInsertionsManyObjectsFewThreads[DRL=sharedSubnetworkAccumulateRule, KieBase type=CLOUD_IDENTITY] test timed out after 80000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest.testConcurrentInsertionsManyObjectsSingleThread[DRL=sharedSubnetworkAccumulateRule, KieBase type=CLOUD_IDENTITY] test timed out after 80000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest.testConcurrentInsertionsFewObjectsManyThreads[DRL=sharedSubnetworkAccumulateRule, KieBase type=CLOUD_IDENTITY] test timed out after 80000 milliseconds
org.drools.mvel.integrationtests.concurrency.ConcurrentInsertionsToSubnetworksTest.testConcurrentInsertionsNewSessionEachThreadUpdate[DRL=sharedSubnetworkAccumulateRule, KieBase type=CLOUD_IDENTITY] test timed out after 80000 milliseconds

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitgabrio LGTM, thank you. I just suggest adding a readme file that explains the scope of the module and describes its organization (eg. invalid vs valid classification)

@gitgabrio gitgabrio merged commit 32c2ac2 into apache:main Mar 22, 2024
9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1023 branch March 22, 2024 07:21
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 27, 2024
…ources module (apache#5796)

* [incubator-kie-issues#1023] Refactored structure of kie-dmn-test-resources. Moved files from jitexecutor

* [incubator-kie-issues#1023] Add Readme from PR suggestion

---------

Co-authored-by: Gabriele-Cardosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN - move significant models to test-resources module
4 participants