[incubator-kie-drools#5776] [new-parser] failed to parse when a metho… #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d name is a drl keyword
tkobayas
commented
Mar 14, 2024
| ; | ||
|
|
||
| // matches any identifiers including acceptable java keywords (defined in JavaParser.g4) and drl keywords | ||
| drlIdentifier returns [Token token] |
There was a problem hiding this comment.
We need to define this rule to aggregate acceptable tokens.
tkobayas
commented
Mar 14, 2024
Comment on lines
-611
to
+681
| | i1=IDENTIFIER { helper.emit($i1, DroolsEditorType.IDENTIFIER); } | ||
| | i1=drlIdentifier { helper.emit($i1.token, DroolsEditorType.IDENTIFIER); } |
There was a problem hiding this comment.
I have fixed only primary rule to make this PR concise and easy to review. I filed #5784 to review DRL6Expressions.g4 for other possible IDENTIFIER replacement.
|
Before PR: After PR: |
|
@yurloc @gitgabrio @mariofusco Please review, thanks! |
mariofusco
approved these changes
Mar 14, 2024
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Jun 11, 2024
…d name is a drl keyword (apache#5783)
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 2, 2024
…d name is a drl keyword (apache#5783)
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 11, 2024
…d name is a drl keyword (apache#5783)
tkobayas
added a commit
that referenced
this pull request
Oct 11, 2024
…d name is a drl keyword (#5783)
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Oct 24, 2024
…d name is a drl keyword (apache#5783)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d name is a drl keyword
Issue:
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.