Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-drools#5707] [new-parser] null-safe dereferencing broken #5771

Merged

Conversation

tkobayas
Copy link
Contributor

@tkobayas tkobayas commented Mar 7, 2024

Issue:

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@tkobayas
Copy link
Contributor Author

tkobayas commented Mar 7, 2024

Before PR:
drools-model-codegen
[ERROR] Tests run: 2433, Failures: 397, Errors: 7, Skipped: 9

After PR:
drools-model-codegen
[ERROR] Tests run: 2433, Failures: 370, Errors: 7, Skipped: 9

@tkobayas
Copy link
Contributor Author

tkobayas commented Mar 7, 2024

NullSafeDereferencingTest is mostly fixed by this PR, but NullSafeDereferencingTest.testNullSafeDereferncingWithInstanceof is still failing. This looks to be another issue, so I filed a separate issue: #5773

@tkobayas
Copy link
Contributor Author

tkobayas commented Mar 7, 2024

@yurloc @gitgabrio @mariofusco Please review, thanks!

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tkobayas LGTM!

@tkobayas tkobayas requested a review from mariofusco March 8, 2024 07:54
@tkobayas tkobayas force-pushed the incubator-kie-drools-5707-null-safe branch from 3852e81 to 8d7fb20 Compare March 8, 2024 08:38
@tkobayas
Copy link
Contributor Author

tkobayas commented Mar 8, 2024

Rebased to solve a conflict

@tkobayas
Copy link
Contributor Author

tkobayas commented Mar 8, 2024

I find also NullSafeDereferencingTest.testNullSafeDereferencingPredicateMethod failed. It is a side-effect of #5767 . I filed a separate issue for this : #5776

Copy link
Contributor

@yurloc yurloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@tkobayas tkobayas merged commit 7c6b18a into apache:dev-new-parser Mar 9, 2024
0 of 3 checks passed
@yurloc
Copy link
Contributor

yurloc commented Mar 11, 2024

Fixing progress: There were 428 failed tests (-29).

tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants