[kie-issues#969]: Negated value in accumulate function ends with Invalid expression error #5762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucamolteni
approved these changes
Mar 5, 2024
gitgabrio
requested changes
Mar 5, 2024
|
|
||
| Results results = createKieBuilder(str).getResults(); | ||
| if (testRunType.isExecutableModel()) { | ||
| System.out.println(results.getMessages(Message.Level.ERROR).get(0).getText()); |
There was a problem hiding this comment.
Thanks @yesamer
Could you please remove this System.out.println ?
| @@ -406,10 +414,10 @@ private boolean parameterNeedsConvertionToMethodCallExpr(Expression accumulateFu | |||
| return accumulateFunctionParameter.isMethodCallExpr() || accumulateFunctionParameter.isArrayAccessExpr() || accumulateFunctionParameter.isFieldAccessExpr(); | |||
| } | |||
|
|
|||
| private Optional<NewBinding> binaryExprParameter(PatternDescr basePattern, AccumulateDescr.AccumulateFunctionCallDescr function, MethodCallExpr functionDSL, String bindingId, String accumulateFunctionParameterStr) { | |||
| private Optional<NewBinding> binaryOrUnaryExprParameter(PatternDescr basePattern, AccumulateDescr.AccumulateFunctionCallDescr function, MethodCallExpr functionDSL, String bindingId, String accumulateFunctionParameterStr) { | |||
There was a problem hiding this comment.
HI @yesamer
Would it make sense to rename it as bindingParameter or similar ?
- if, by chance, we discover that another kind of expression has to be managed here, the method name would become awfull
- usually, the method name express the returned object
- IINW, nothing prevent this method to be invoked by somehting different then a
BinaryExpror aUnaryExpr(if it is implicitily so, I think there should be a check/guard somehow)
WDYT ?
yesamer
changed the title
gitgabrio
approved these changes
Mar 5, 2024
baldimir
approved these changes
Mar 6, 2024
yesamer
added a commit
to yesamer/drools
that referenced
this pull request
Mar 7, 2024
…lid expression error (apache#5762) * Added Unary Expression management * Improved DroolsMvelParserTest * Typo * Exception message updated * Code review * Code review (cherry picked from commit 2ac36ac)
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Mar 11, 2024
…lid expression error (apache#5762) * Added Unary Expression management * Improved DroolsMvelParserTest * Typo * Exception message updated * Code review * Code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: apache/incubator-kie-issues#969
This case leads to an
Invalid expression -$p.getAge()error.That is because the UnaryExpression types are not managed in the
AccumulateVisitorlogic.To fix the issue, I managed that case relying on the existing BinaryExpression logic management, which fits well for the
UnaryExpressioncase according to my analysis.Please correct me if I'm wrong @lucamolteni @mariofusco.
In addition, we added a check to ensure that the accumulate function always has no more than one parameter (kudos to @gitgabrio ). I added that check for the executable Model case only
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request and downstream checks
for a full downstream build
run_fdbfor Jenkins PR check only
Build Nowbutton.