Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#903] Add reflect-config.json files related to drools-commands. #5671

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

baldimir
Copy link
Contributor

@baldimir baldimir commented Feb 2, 2024

Copy link
Contributor

@gitgabrio gitgabrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @baldimir
THose changes seems fine, but we need a test to verify

  1. they does not break anything
  2. that solve the issue they are required for

Could you please create a kogito-example that makes use of such classes and pair with this PR ? THanks

@baldimir
Copy link
Contributor Author

baldimir commented Feb 7, 2024

After discussion with Gabriele, I am merging this, he is fine merging this as it is.

@baldimir baldimir merged commit d8462f8 into apache:main Feb 7, 2024
9 checks passed
baldimir added a commit to baldimir/drools that referenced this pull request Feb 14, 2024
baldimir added a commit that referenced this pull request Feb 14, 2024
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 11, 2024
@baldimir baldimir deleted the drools-commands-reflectconfig branch April 11, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reflect-config.json configuration to drools-commands and relevant other modules
4 participants