[GLUTEN-8655][CH] Refactor: remove clickhouse.lib.path #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 3, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 3, 2025
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 3, 2025
|
Run Gluten Clickhouse CI on x86 |
baibaichen
force-pushed
the
feature/spark.gluten.sql.columnar.libpath
branch
from
70a39fd to
9f48967
Compare
|
Run Gluten Clickhouse CI on x86 |
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 4, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 4, 2025
baibaichen
added a commit
to baibaichen/gluten
that referenced
this pull request
Feb 4, 2025
baibaichen
force-pushed
the
feature/spark.gluten.sql.columnar.libpath
branch
from
9f48967 to
d0f0ec5
Compare
|
Run Gluten Clickhouse CI on x86 |
This reverts commit cd00681.
baibaichen
force-pushed
the
feature/spark.gluten.sql.columnar.libpath
branch
from
d0f0ec5 to
a6ade57
Compare
|
Run Gluten Clickhouse CI on x86 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Fixes: #8655)
clickhouse.lib.pathwas used at the beginning of this project, and now it should be usingspark.gluten.sql.columnar.libpath, so that we needn't call.set(GlutenConfig.GLUTEN_LIB_PATH.key, SystemParameters.getClickHouseLibPath)when initializingSparkConf.Notes: After this PR, the signifiant change is how to set debug parameters in IDEA
tpcds.data.path=/data/tpcds-data-sf1-D
clickhouse.lib.path=/path/to/gluten/cpp-ch/build/utils/extern-local-engine/libch.so-Dspark.test.home=/path/to/spark33
-Dspark.gluten.sql.columnar.libpath=/path/to/gluten/cpp-ch/build/utils/extern-local-engine/libch.so
-Dspark.test.home=/path/to/spark33
How was this patch tested?
Using exited UTs