[GLUTEN-8616] [VL] Make filescan limit for encrypted fallback as configurable #8621
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI on x86 |
ArnavBalyan
force-pushed
the
arnavb/configurable-limit
branch
from
acbcc3f to
fc66b86
Compare
|
Run Gluten Clickhouse CI on x86 |
ArnavBalyan
force-pushed
the
arnavb/configurable-limit
branch
from
fc66b86 to
ce47d23
Compare
|
Run Gluten Clickhouse CI on x86 |
|
cc @zhztheplayer could you please review thanks! |
jackylee-ch
reviewed
Jan 28, 2025
| .doc("If supplied, `limit` number of files will be checked to determine encryption " + | ||
| "and falling back java scan") | ||
| .intConf | ||
| .createWithDefault(10) |
There was a problem hiding this comment.
nit: checkValue is required here to ensure the data is non-negative.
ArnavBalyan
force-pushed
the
arnavb/configurable-limit
branch
from
ce47d23 to
9a27d24
Compare
|
Run Gluten Clickhouse CI on x86 |
|
cc @jackylee-ch fixed, can you please take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?