Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker-compose): add a way to change default datasource #8127

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(docker-compose): add a way to change default datasource #8127

wants to merge 6 commits into from

Conversation

riipeckx
Copy link

@riipeckx riipeckx commented Oct 2, 2024 •
edited
Loading

Summary

As I'd like to use PostgreSQL, I added a way to set the default datasource via environment variables.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. component/ext This issue or PR relates to external components, such as Grafana pr-type/feature-development This PR is to develop a new feature labels Oct 2, 2024
@klesh
Copy link
Contributor

klesh commented Oct 8, 2024

LGTM, did you test it? did it work?

@riipeckx
Copy link
Author

riipeckx commented Oct 8, 2024

LGTM, did you test it? did it work?

I tested it locally, and it worked well :)

@riipeckx riipeckx mentioned this pull request Oct 31, 2024
Open
3 tasks
@klesh
Copy link
Contributor

klesh commented Nov 1, 2024

I am afraid this would affect helm chart and release procedure as well.
We need more input about this
@matrixji @JorgeGar @d4x1 What do you guys think?

@d4x1
Copy link
Contributor

d4x1 commented Nov 1, 2024

@klesh Yes hel charts should be updated too
@riipeckx https://github.com/apache/incubator-devlake-helm-chart/blob/main/charts/devlake/values.yaml

@vi-mer
Copy link

vi-mer commented Nov 12, 2024

I'll check this out asap :)

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Nov 14, 2024
@riipeckx
Copy link
Author

riipeckx commented Nov 15, 2024 •
edited
Loading

I'm working on helm charts updates in the given repo.

klesh
klesh reviewed Nov 19, 2024
View reviewed changes
Copy link
Contributor

@klesh klesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most Grafana dashboards are using MySQL dialect AFAIK.
I don't think it is a good idea to touch them 😂, are you planning to rewrite all those queries.

@d4x1
Copy link
Contributor

d4x1 commented Nov 19, 2024

LGTM. Please consider @klesh 's comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klesh klesh klesh left review comments

@vi-mer vi-mer vi-mer approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
component/ext This issue or PR relates to external components, such as Grafana pr-type/feature-development This PR is to develop a new feature size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@riipeckx @klesh @d4x1 @vi-mer